Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: using font-awesome CDN #1346

Merged
merged 1 commit into from
Jun 2, 2018
Merged

temp: using font-awesome CDN #1346

merged 1 commit into from
Jun 2, 2018

Conversation

thelostone-mc
Copy link
Member

Description

Not sure what is being missed here, so shifting to FA CDN until resolved

screen shot 2018-06-02 at 11 35 45 pm

screen shot 2018-06-02 at 11 35 51 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines

@ghost ghost assigned thelostone-mc Jun 2, 2018
@ghost ghost added the in progress label Jun 2, 2018
@codecov
Copy link

codecov bot commented Jun 2, 2018

Codecov Report

Merging #1346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1346   +/-   ##
=======================================
  Coverage   30.63%   30.63%           
=======================================
  Files         124      124           
  Lines        8783     8783           
  Branches     1141     1141           
=======================================
  Hits         2691     2691           
  Misses       5984     5984           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6860c3...34c2a3b. Read the comment docs.

@arku
Copy link
Contributor

arku commented Jun 2, 2018

@thelostone-mc I see the request being sent to https://gitcoin.co/v2/css/fontawesome-all.min.css

I am not sure how static files are handled in Django, shouldn't it instead be https://gitcoin.co/static/v2/css/fontawesome-all.min.css 🤔 ?

I tried hitting https://gitcoin.co/static/v2/css/fontawesome-all.min.css but didn't work.

@thelostone-mc
Copy link
Member Author

@arun1595 Ah I know 😓
waiting on the team to help out, if everyone is out -> I'll revert the other PR and restore it to the older state in a bit

@arku
Copy link
Contributor

arku commented Jun 2, 2018

@thelostone-mc I did a bit of reading on staticfiles in django and it looks like you've to run python manage.py collectstatic on the server to copy the static files into /static.

What do you think? And correct me if I am wrong.

@SaptakS SaptakS merged commit fb79fd3 into master Jun 2, 2018
@ghost ghost removed the in progress label Jun 2, 2018
@thelostone-mc
Copy link
Member Author

@arun1595 Yeah I saw that in the docs!
https://docs.djangoproject.com/en/1.11/howto/static-files/

@mbeacom mbeacom deleted the tlo-mc/bug branch June 4, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants