Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the scope of GH perms requested on login #1328

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jun 1, 2018

Description

The goal of this PR is to reduce the initial permissions we request for users.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

auth

@mbeacom mbeacom added the backend This needs backend expertise. label Jun 1, 2018
@ghost ghost assigned mbeacom Jun 1, 2018
@ghost ghost added the in progress label Jun 1, 2018
@mbeacom mbeacom assigned owocki and SaptakS and unassigned mbeacom Jun 1, 2018
@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #1328 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   30.83%   30.83%           
=======================================
  Files         124      124           
  Lines        8738     8738           
  Branches     1146     1146           
=======================================
  Hits         2694     2694           
  Misses       5933     5933           
  Partials      111      111
Impacted Files Coverage Δ
app/app/settings.py 83.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3c26c...92d45e7. Read the comment docs.

@mbeacom mbeacom closed this Jun 1, 2018
@ghost ghost removed the in progress label Jun 1, 2018
@mbeacom mbeacom deleted the mark-decrease-gh-perms branch June 1, 2018 12:34
@mbeacom mbeacom restored the mark-decrease-gh-perms branch June 1, 2018 12:54
@mbeacom mbeacom reopened this Jun 1, 2018
@ghost ghost assigned mbeacom Jun 1, 2018
@ghost ghost added the in progress label Jun 1, 2018
@mbeacom mbeacom merged commit d68ad72 into master Jun 1, 2018
@ghost ghost removed the in progress label Jun 1, 2018
@mbeacom mbeacom deleted the mark-decrease-gh-perms branch June 1, 2018 12:55
@SaptakS
Copy link
Contributor

SaptakS commented Jun 1, 2018

Nice!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants