Quickstart PR with corrected redirect #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
+ Coverage 30.63% 30.64% +0.01%
==========================================
Files 124 124
Lines 8784 8790 +6
Branches 1141 1141
==========================================
+ Hits 2691 2694 +3
- Misses 5985 5988 +3
Partials 108 108
Continue to review full report at Codecov.
|
…into feature/quickstart-screen
|
This is currently live on https://stage.gitcoin.co Bugs so far:
|
mbeacom
suggested changes
May 29, 2018
mbeacom
changed the title
|
|
SaptakS
changed the title
app/assets/v2/css/base.css
Outdated
| background-color: #FF6700; | ||
| } | ||
|
|
||
|
|
app/assets/v2/css/base.css
Outdated
| } | ||
|
|
||
| .submit-notification a { | ||
| color: #fff; |
There was a problem hiding this comment.
Don't hate me for this but can we uppercase this ( to keep it uniform )
There was a problem hiding this comment.
or lower case everything! we'll have work either way
|
LGTM left a few minor comments |
SaptakS
force-pushed
the
feature/quickstart-screen
branch
from
9d1f94f to
0c25ca4
Compare
mbeacom
approved these changes
Jun 4, 2018
This was referenced Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes
Refs #1029