ftux: refactor + restructure + url rename #1281
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
- Coverage 31.26% 31.22% -0.04%
==========================================
Files 120 120
Lines 8397 8397
Branches 1100 1100
==========================================
- Hits 2625 2622 -3
- Misses 5663 5666 +3
Partials 109 109
Continue to review full report at Codecov.
|
thelostone-mc
added
frontend
| </script> | ||
| <script> | ||
| var steps = []; | ||
| var flow = "{{flow}}" |
There was a problem hiding this comment.
It helps with the URL redirection :P
There was a problem hiding this comment.
haha - I know. I wasn't talking about the flow and step args exactly xD {{flow}} 😁
| return TemplateResponse(request, 'onboard.html', params) | ||
| params = { | ||
| 'title': _('Onboarding Flow'), | ||
| 'steps': ['github', 'metamask', 'avatar', 'skills'], |
There was a problem hiding this comment.
Pretty much what I was thinking. Ideally, we'd take this a step ( 😁) further to allow us to provide the series of steps defined somewhere on the BE based on the user type or other criteria... Thoughts?
There was a problem hiding this comment.
Pretty much what I was thinking.
Sauron is pleased :P
Couldn't we just add that logic in here ?
profile.getUserType() --> based on that we specify flow !
Any benefits your approach would offer over the one you laid out there ? (I probably didn't get this 😅 )
|
@mbeacom good for merge ? |
Description
One step closer to achieving modularity
onboard.htmlviews-> and accordingly the flow will be builtftuxfolder making it easier to maintain@mbeacom Is this something along the lines of what you had in mind ?
Checklist
Affected core subsystem(s)
Refers/Fixes