Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaderboard updates for mitch #1275

Merged
merged 1 commit into from
May 28, 2018
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented May 25, 2018

  1. adds the ability to filter on org name
  2. adds num bounties in addition to just the amount funded

screencapture-localhost-8000-leaderboard-quarterly_orgs-2018-05-25-14_00_18

@ghost ghost assigned owocki May 25, 2018
@ghost ghost added the in progress label May 25, 2018
@mkosowsk
Copy link

@owocki Thanks a lot! Please ping me here when this dude is merged, this will really help my workflow :)

@owocki owocki merged commit d10e067 into master May 28, 2018
@ghost ghost removed the in progress label May 28, 2018
@owocki
Copy link
Contributor Author

owocki commented May 28, 2018

@@ -164,6 +164,8 @@ class LeaderboardRank(SuperModel):
leaderboard = models.CharField(max_length=255)
amount = models.FloatField()
active = models.BooleanField()
count = models.IntegerField(default=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to denormalize the count field here? We could benefit from queryset caching and might not have a need for maintaining this field moving forward. How's the overhead for the operation to update this count/rank?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where it's computed -> https://github.com/gitcoinco/web/pull/1275/files#diff-c672b9ab5fac2576200d174f3f05baf0R80

we'd have to change the way we store / compute the info in this PR to do this. not sure the performance implications, but right now the assemble_leaderboards script is fairly fast. its about 15s for the script to run once a day

@mbeacom mbeacom deleted the kevin/leaderboardupdatesformitch branch May 28, 2018 15:13
@mkosowsk
Copy link

@owocki Excellent, thanks a million!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants