Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified web3 address to be optional for EthOS #1148

Merged
merged 4 commits into from
May 11, 2018
Merged

Modified web3 address to be optional for EthOS #1148

merged 4 commits into from
May 11, 2018

Conversation

eswarasai
Copy link
Contributor

No description provided.

@thelostone-mc thelostone-mc requested review from thelostone-mc and mbeacom and removed request for thelostone-mc May 11, 2018 15:28
@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #1148 into master will decrease coverage by 0.04%.
The diff coverage is 19.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   31.84%   31.79%   -0.05%     
==========================================
  Files         115      115              
  Lines        7804     7819      +15     
  Branches     1009     1012       +3     
==========================================
+ Hits         2485     2486       +1     
- Misses       5210     5224      +14     
  Partials      109      109
Impacted Files Coverage Δ
app/ethos/utils.py 22.41% <27.77%> (+2.41%) ⬆️
app/ethos/views.py 22.72% <4.16%> (+0.4%) ⬆️
app/ethos/models.py 34.88% <60%> (-0.38%) ⬇️
app/app/settings.py 83.04% <0%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7846a...34b49d6. Read the comment docs.

thelostone-mc
thelostone-mc previously approved these changes May 11, 2018
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that seems to have covered everything that @owocki had asked for.

@mbeacom ?

@mbeacom mbeacom merged commit 831821d into gitcoinco:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants