Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix roadmap items shift #100 #113

Merged
merged 1 commit into from
Dec 14, 2017
Merged

fix roadmap items shift #100 #113

merged 1 commit into from
Dec 14, 2017

Conversation

alx
Copy link
Contributor

@alx alx commented Dec 14, 2017

Some blocks still shift and it shifts when content fits, see:
https://drive.google.com/open?id=1Oaj7HIMb9gt4PPbd6x0w06njsiicXf2v

css: fix roadmap items shift by reducing padding on div :hover

Fixes: #100

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description with a short description on what the change is ? ^_^
Makes reviewing a tab bit easier. (Along with the issue it refers to )

PS: if it's not too much of a trouble, maybe edit the commit message to

css: fix roadmap items shift 

Fixes: #100 

(On the off chance you need help with this, let me know)

This PR fixes the issue -> adding the Fixes: would close the issue on it's own upon being merged.
Makes @owocki s life easier :)

@alx
Copy link
Contributor Author

alx commented Dec 14, 2017

Thanks for your help @thelostone-mc I've corrected the PR accordingly

@owocki
Copy link
Contributor

owocki commented Dec 14, 2017

LGTM -- thanks @alx !

@owocki owocki merged commit 0548c4d into gitcoinco:master Dec 14, 2017
@alx alx deleted the patch-1 branch December 14, 2017 15:42
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.005 ETH ($3.28) has been granted to @alx for this issue. ⚡️

Nice work @alx, check your email for further instructions.

ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018
owocki pushed a commit that referenced this pull request Apr 30, 2021
update to work with new wallet.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: roadmap items shift to adjust for content on hover
4 participants