Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: fixed overflow scroll on tip recieve page #109

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Dec 13, 2017

Problem:

On this tip, the background image overflows (as the position keeps changing ) cause the screen to be scroll-able as the screen bg changes position, bad user experience.

overflow-scroll

Fix: A single line of css

@owocki Might need an extra pair of eyes to look into this , to make sure nothing else is broken.

@owocki
Copy link
Contributor

owocki commented Dec 13, 2017

tested LGTM

@owocki owocki merged commit 9a18968 into gitcoinco:master Dec 13, 2017
@owocki
Copy link
Contributor

owocki commented Dec 13, 2017

just sent ya a tip :) appreciate it

ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018
css: fixed overflow scroll on tip recieve page
owocki pushed a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants