Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: side_bar filters refactor #1082

Merged
merged 1 commit into from
May 7, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

Description
  • ensure that 'any' is deselected if any option is available via local
    storage
  • reindented + reused code
Before

x

After

x

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • js
Refers/Fixes

- ensure that 'any' is deselected if any option is available via local
  storage
- reindented + reused code

Fixes: gitcoinco#1064
@codecov
Copy link

codecov bot commented May 6, 2018

Codecov Report

Merging #1082 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
- Coverage      32%   31.96%   -0.05%     
==========================================
  Files         105      105              
  Lines        7284     7284              
  Branches      948      948              
==========================================
- Hits         2331     2328       -3     
- Misses       4845     4848       +3     
  Partials      108      108
Impacted Files Coverage Δ
app/app/settings.py 80.79% <0%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f85e0...75041a4. Read the comment docs.

@mbeacom mbeacom merged commit e57c207 into gitcoinco:master May 7, 2018
@thelostone-mc thelostone-mc deleted the bug branch May 10, 2018 09:42
matthewlilley pushed a commit to matthewlilley/web that referenced this pull request May 11, 2018
- ensure that 'any' is deselected if any option is available via local
  storage
- reindented + reused code

Fixes: gitcoinco#1064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants