Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve pytest / travis failures #987

Closed
mbeacom opened this issue Apr 26, 2018 · 0 comments
Closed

Resolve pytest / travis failures #987

mbeacom opened this issue Apr 26, 2018 · 0 comments
Labels
backend This needs backend expertise.

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Apr 26, 2018 •
edited
Loading

BE tests are currently failing since the changes introduced in:

  • verboseness of gitcoinbot reminders #931 (3 failures)

    • test_assemble_leaderboards.py:128: AssertionError
    • test_assemble_leaderboards.py:111: AssertionError
    • test_expiration_start_work.py:114: AssertionError

  • smarter github notifications #948 (4 failure)

    • test_notifications.py:75: AssertionError
    • test_notifications.py:68: AssertionError
    • test_notifications.py:60: AssertionError
    • test_expiration_start_work.py:114: AssertionError

Current failing build example: https://travis-ci.org/gitcoinco/web/jobs/371318290

Walkthrough code changes and determine what has changed and why the tests are now failing.

Is this due to intended changes that require modifying the tests to meet our new expectations or are these legitimate failures in our desired end result?
@mbeacom mbeacom added backend This needs backend expertise. tests labels Apr 26, 2018
@mbeacom mbeacom self-assigned this Apr 26, 2018
owocki added a commit that referenced this issue Apr 26, 2018
@owocki
https://github.com/gitcoinco/web/issues/987
c9ba80a
@owocki owocki closed this as completed in 2102eb8 Apr 26, 2018
owocki added a commit that referenced this issue Apr 26, 2018
@owocki
fixes #987
533af63
@mbeacom mbeacom removed their assignment Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend This needs backend expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbeacom