Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and check all possible status values #816

Closed
abitrolly opened this issue Apr 6, 2018 · 4 comments
Closed

Document and check all possible status values #816

abitrolly opened this issue Apr 6, 2018 · 4 comments

Comments

@abitrolly
Copy link
Contributor

User Story

As a gitcoin developer, I'd like to know about all possible bounty statuses to make interfaces that don't miss any info.

Why Is this Needed?

Because Killed status is still visible as Expiring after this commit https://github.com/gitcoinco/web/pull/785/files With a graph of possible statuses, it is easier to cover all cases.

@thelostone-mc
Copy link
Member

Ah that's a good catch!
Will throw in a fix for that

thelostone-mc pushed a commit to thelostone-mc/web that referenced this issue Apr 6, 2018
@owocki
Copy link
Contributor

owocki commented Apr 6, 2018

does this screenshot from the side bar ( http://bits.owocki.com/0F1W211g3a0N/Screen%20Shot%202018-04-06%20at%208.04.58%20AM.png ) help?

how about this visual one? http://bits.owocki.com/0k3S1n111v1c/Screen%20Shot%202018-04-06%20at%208.06.00%20AM.png

@mbeacom mbeacom closed this as completed in f179b8e Apr 6, 2018
@abitrolly
Copy link
Contributor Author

Visual one is better.

@abitrolly
Copy link
Contributor Author

Although Kill/Cancel action/status wants to be consistent. It is not always clear that it is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants