Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user who created a grant transaction that failed or is pending forever, I want a notification so I can resubmit it. #6556

Closed
owocki opened this issue May 1, 2020 · 11 comments · Fixed by #6791

Comments

@owocki
Copy link
Contributor

owocki commented May 1, 2020

User Story

As a user who created a grant transaction that failed or is pending forever, I want a notification so I can resubmit it.

Why Is this Needed

Summary:
Bc it stinks to contribute and have it not work bc of Ethereum gas or some other technical issue.

Description

Type:
Feature

Current Behavior

management command update_tx_status marks txns as failed in DB

Expected Behavior

  • move from the old validator (update_tx_status) to the new one (validate_grant_contributions) bc the old one only checks for txn exit state, and doesnt properly check for a transfer event. new validator also checks for dropped/replaced txns
  • if a txn has been pending for more than 24 or 48 hours, send user a reminder asking them to speed up a txn (link to helpdesk article at http://gitcoin.co/gas/faq)
  • if a txn has failed, email the user + ask the user to retry the txn (and give them a one click 're-add to cart' option to do it)

Definition of Done

Data Requirements

comment: # (How will we measure the success of this feature? What kind of tracking is needed for this feature (clicks, impressions, flag)?)

Additional Information

@owocki
Copy link
Contributor Author

owocki commented May 18, 2020

@willsputra could i get a quickie email design for this? just a link to the txid and the ability to re-submit it is all the email needs to do.

@owocki
Copy link
Contributor Author

owocki commented Jun 1, 2020

@willsputra bump ^^

@willsputra
Copy link
Contributor

just saw this! will do

@willsputra
Copy link
Contributor

@owocki @PixelantDesign something like this?
tx failed email

@owocki
Copy link
Contributor Author

owocki commented Jun 1, 2020

yes this works for me.

@sebastiantf any interest in coding this up?

@sebastiantf
Copy link
Contributor

Yeah sure

@owocki
Copy link
Contributor Author

owocki commented Jun 4, 2020

@sebastiantf can you get a PR in by sunday ? just remind me after via https://gitcoin.co/requestmoney to get paid

@sebastiantf
Copy link
Contributor

I shall try @owocki. I'm currently working on the Grants recontribute email.

@owocki
Copy link
Contributor Author

owocki commented Jun 4, 2020 via email

@sebastiantf
Copy link
Contributor

@owocki I have a PR up for the email: #6791

@owocki
Copy link
Contributor Author

owocki commented Jun 8, 2020

thanks- looking really good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants