Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a funder/contributor I'd like to know who I'm following and who is following me on the Gitcoin platform. #6095

Closed
PixelantDesign opened this issue Feb 28, 2020 · 29 comments
Closed

As a funder/contributor I'd like to know who I'm following and who is following me on the Gitcoin platform. #6095

PixelantDesign opened this issue Feb 28, 2020 · 29 comments
Labels
backend This needs backend expertise. For Contributor frontend This needs frontend expertise.

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Feb 28, 2020 •
edited
Loading

User Story

As a funder/contributor I'd like to know who I'm following and who is following me on the Gitcoin platform.

Why Is this Needed

On profile, a follower count is displayed but does not say who. It also doesn't show me who I'm following. This is a front end and backend ticket.

Description

Type: Feature

Current Behavior

Follower count is displayed but does not say who

Expected Behavior

Show who I'm following, show who is following me

Definition of Done

  • The build looks and works as designed.
  • Add a follow tab on profile (use existing style on that page)
  • Add a follow/following section under that tab (use existing style on that page)
  • There is a way to see who follows me and who I'm following
  • Unfollow button works
  • Follow button works

Add following/followers section
Screen Shot 2020-02-28 at 6 15 59 AM

Show who I'm following
Screen Shot 2020-02-28 at 6 15 21 AM

Show ability to unfollow on hover
Screen Shot 2020-02-28 at 6 15 35 AM

On follower tab - show who is following me
show a button so that a user can follow back

Screen Shot 2020-02-28 at 6 15 41 AM

Additional Information

Screen Shot 2020-02-28 at 6 32 58 AM

Screen Shot 2020-02-28 at 6 32 45 AM
@PixelantDesign PixelantDesign added frontend This needs frontend expertise. backend This needs backend expertise. For Contributor labels Feb 28, 2020
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 1.4 ETH (315.24 USD @ $225.17/ETH) attached to it.

@zoek1
Copy link
Contributor

zoek1 commented Feb 28, 2020

In case the assigned user couldn't start this task, I'll happy to work on this. I think I could finish this weekend

@gitcoinbot
Copy link
Member

gitcoinbot commented Feb 28, 2020 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 month ago.
Please review their action plans below:

1) jschiarizzi has started work.

Start with new tab on profile
break into two toggle-able sides for followers and following people.
generate list of each group via follower storage.
implement buttons as designed

Learn more on the Gitcoin Issue Details page.

@danlipert
Copy link
Contributor

@jschiarizzi @PixelantDesign for this to have good performance we'll want to make sure to have pagination via a show more button at the bottom of the list, or infinite scroll. Also, would be nice to have a search bar that filters the results as you type so that you can look up a specific user

@cupOJoseph
Copy link
Contributor

thanks for the input, @danlipert. search is probably not in this scope, but I was thinking infinite scroll after 50 users at time? not many people have much more than that for followers at the moment.

@PixelantDesign
Copy link
Contributor Author

Sounds good @jschiarizzi! Looking forward to seeing a PR!

@cupOJoseph
Copy link
Contributor

Monday update: went to west virginia to drink moonshine instead of work on this over the weekend. Will have a better update by tomorrow night.

@cupOJoseph
Copy link
Contributor

cupOJoseph commented Mar 4, 2020 •
edited
Loading

update: took me longer than I care to admit to get oauth running locally this evening. A challenge is testing followers locally since no one else follows my local profile on my local machine haha

update adds new FOLLOW tab
It steals all the structure of the ACTIVITY feed, but we can just loop through followers instead of recent activity for the list. I didnt realize before, but the activity feed uses infinite scroll, I see no reason to change how thats already implemented.

tomorrow:

  • connect actual follower actions to buttons. this is implemented already in profiles/follow.html
  • make pretty follow, unfollow buttons:
    <button class="btn btn-gc-pink btn-sm m-2 px-2 font-caption" data-jointribe="{{profile.handle}}">Unfollow<i class="fas fa-user-minus font-smaller-4 ml-2"></i></button>
    <button class="btn btn-gc-blue btn-sm m-2 px-2 font-caption" data-jointribe="{{profile.handle}}">Follow<i class="fas fa-user-plus font-smaller-4 ml-2"></i></button>

@danlipert
Copy link
Contributor

@jschiarizzi you should test by setting up multiple users in your local. I know Github limits users to one account so either create superusers through the django createsuperuser command or create one superuser first (you'll want to do this anyway to access the django admin) and then create them manually in the admin

@cupOJoseph
Copy link
Contributor

thanks for the tip @danlipert, thats very helpful

@cupOJoseph
Copy link
Contributor

Still here. Will have a bigger update tonight.

@PixelantDesign
Copy link
Contributor Author

Looking forward to it @jschiarizzi !

@cupOJoseph
Copy link
Contributor

cupOJoseph commented Mar 11, 2020 •
edited
Loading

I made some more commits. the last thing I'm missing from the design is the different color [Following] and [Unfollow] and [Follow] buttons.

Still struggling to test this with users, i dont understand how the users i've created in django can interact. I followed the docs to make a superuser and then added some new test users and data. but when i look for their profile in localhost:8080/profile/myTestUser I just get 404s.

Screen Shot 2020-03-10 at 9 30 33 PM

Screen Shot 2020-03-10 at 9 27 43 PM

@cupOJoseph
Copy link
Contributor

The world was been a little crazy the last few days. I'm still here. Planning to spend some more time figuring out the django setup tomorrow.

@PixelantDesign
Copy link
Contributor Author

Thanks for the update @jschiarizzi

@cupOJoseph
Copy link
Contributor

Sometimes getting weird errors trying to load everything after making changes in django. I'm not touching townhall so why is this breaking things
Screen Shot 2020-03-19 at 7 53 22 PM

@owocki
Copy link
Contributor

owocki commented Mar 20, 2020 via email

@cupOJoseph
Copy link
Contributor

I cloned master for https://github.com/jschiarizzi/web

@owocki
Copy link
Contributor

owocki commented Mar 23, 2020 via email

@cupOJoseph cupOJoseph mentioned this issue Mar 26, 2020
Merged
@cupOJoseph
Copy link
Contributor

cupOJoseph commented Mar 26, 2020 •
edited
Loading

Okay so this doesnt work yet, @zoek1 would you help me finish it?

Some good helpful things:

  • using https://github.com/gitcoinco/web/pull/6301/files as an example to of making a new profile tab
  • Adding the new tab activation in tab.html in web/app/dashboard/templates/profiles
  • Adding new follow tab template in for tab_follow in web/app/dashboard/templates/profiles

Some work still on

  • use views.py in /web/app/dashboard/ to grab the list of following users for a given profile and filter it based on following or followers. like ugh why is it called a tribe
  • "also followed by" these people section for each user in the list

@PixelantDesign
Copy link
Contributor Author

Thanks for the update @jschiarizzi! @zoek1 are you able to help get this to the finish line?

@cupOJoseph
Copy link
Contributor

DM-ing on gitcoin chat with @zoek1 now

@cupOJoseph
Copy link
Contributor

Saturday update, zoek1 and I worked on this for a bit today.

current progress is:
Screen Shot 2020-03-28 at 11 26 42 PM

Just missing a few small beautification things, and the send message button. all the functionality is done. Needs maybe another hour I hope, tomorrow.

@cupOJoseph
Copy link
Contributor

As per Alisa's guidance, just blue follow buttons when you dont follow the user.
Screen Shot 2020-04-02 at 4 11 45 PM

@cupOJoseph
Copy link
Contributor

cupOJoseph commented Apr 5, 2020 •
edited
Loading

#6301

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 1.4 ETH (230.87 USD @ $164.91/ETH) has been submitted by:

  1. @jschiarizzi

@PixelantDesign please take a look at the submitted work:

@gitcoinbot
Copy link
Member

Pythonista ⚡️ A *Pythonista* Kudos has been sent to @jschiarizzi for this issue from @PixelantDesign. ⚡️

The sender had the following public comments:

Thanks for your help!

Nice work @jschiarizzi!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 1.4 ETH (298.1 USD @ $212.93/ETH) attached to this issue has been approved & issued to @jschiarizzi.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 200.00000 DAI (200.0 USD @ $1.0/DAI) has been granted to @zoek1 for this issue from @jschiarizzi. ⚡️

Nice work @zoek1! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend This needs backend expertise. For Contributor frontend This needs frontend expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@PixelantDesign @owocki @zoek1 @danlipert @cupOJoseph @gitcoinbot