Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify docker-compose.yml to reduce running/exited services / persistent volume #58

Closed
mbeacom opened this issue Nov 29, 2017 · 0 comments

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Nov 29, 2017

The current docker-compose.yml defines shell and migration service containers.
I am uncertain what function the shell container provides (if you wish to access the shell of the running web container, you can docker exec -it against it).

Currently, the postgresql data lives as long as the underlying container.
We can preserve the data via a persistent volume.

Additionally, the migration service will always end as exited, meanwhile the docker-compose.bash script runs the migration step before running the test server.

I am proposing we replace the migration service container with either a shell script, makefile entry, README documentation, or a combination to allow users to easily make migrations and migrate the database in the event it's necessary.

The proposed changes will eliminate two of four containers.

@mbeacom mbeacom changed the title Modify docker-compose.yml to reduce running/exited services Modify docker-compose.yml to reduce running/exited services / persistent volume Nov 29, 2017
@owocki owocki closed this as completed in eafaba3 Dec 1, 2017
ethikz pushed a commit to ethikz/web that referenced this issue Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant