Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ability to Resurface Bounties to the Top When Bounty has been Abandoned #4745

Closed
7 tasks
PixelantDesign opened this issue Jul 5, 2019 · 24 comments
Closed
7 tasks

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Jul 5, 2019

Who

User Story

As a Funder, I'd like the ability for issues I've re-marketed to surface to the top of the issue explorer as a newly opened issue.

As a Contributor, I'd like to see re-marketed issues at the top of the issue explorer so I'll know that it is open and available to be worked on.

What

When an issue is remarketed, it should surface to the top of the issue explorer and show up as a new issue in notifiers-gitcoin on slack.

Why

This will help us move issues through the platform.

Definition of Done

  • Build a feature that allows for surfacing to the top of the issue explorer when Funder opts for this option.
  • Create a rule where funder can't do this more than two times (to limit misuse) per discussion with @ceresstation and @PixelantDesign .
  • We only allow remarket if funder has reviewed and rejected all the workers in the list.
  • If there are contributors that have applied (that funder needs to review), the button should be grayed out. When there are no contributors pending, the button becomes active.
  • To clean up the buttons a bit move the Extend Expiration under Edit Issue Details button into dropdown menu. See other existing dropdown styles.
  • Post a video or screenshots of the feature built
  • This issue passes all of the tests and revisions from the Gitcoin Core engineering team.
@octavioamu octavioamu assigned octavioamu and unassigned octavioamu Jul 5, 2019
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 125.0 DAI (125.0 USD @ $1.0/DAI) attached to it.

@PixelantDesign
Copy link
Contributor Author

Reserved for @rafalkowalski

@gitcoinbot
Copy link
Member

gitcoinbot commented Jul 11, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 10 months, 2 weeks from now.
Please review their action plans below:

1) vince0656 has been approved to start work.

Hi there,

Thank you for considering my application to work on this issue. My rough plan for successfully executing this user story is as follows:

  • Isolate the functionality that places new bounties / funded issues at the top of the issue explorer
  • Ascertain whether the aforementioned functionality can be re-used for this user story
  • If the functionality needs breaking out for re-use, then this will need to be completed and must not break the existing listing functionality
  • Expose the new functionality so that existing issues can trigger it
  • Add a button within the issue viewer that can trigger the re-surfacing
    • The trigger should additionally push a message to the #notif-gitcoin slack channel for workers to see
  • Add a counter to track how many times the new re-marketing button has been triggered by a funder and limit its maximum value to 2 (assuming an initial value of 0)
  • Ensure that the re-marketing button is only enabled within an issue when the following conditions have been satisfied:
      1. Any previous workers have either been rejected by a funder or have abandoned the work they started
      1. There are no pending applicants for the issue
      1. The trigger counter value is less than 2
  • Move the Extend Expiration button currently under the Edit Issue Details button
  • Build appropriate tests

The only question I have so far is regarding the following definition of done criteria:

  • To clean up the buttons a bit move the Extend Expiration under Edit Issue Details button into dropdown menu. See other existing dropdown styles.

I understand that the Extend Expiration button needs to be moved into a drop down menu. However, what do you want the new menu to be called and where does it need to be placed? Once I know this, then I can use one of the existing drop down styles.

If you have any questions for myself, please don't hesitate to get in contact.

Kind Regards,
Vincent Almeida

Learn more on the Gitcoin Issue Details page.

@spm32
Copy link
Collaborator

spm32 commented Jul 11, 2019

That sounds great, @PixelantDesign let me know if you have any concerns here and if you're able to answer some of Vince's outstanding questions. In the interim, @vince0656 you're good to go!

@PixelantDesign
Copy link
Contributor Author

PixelantDesign commented Jul 12, 2019

Looking forward to seeing what you come up with @vince0656. The only change we need to make on our side is that we'd like this bounty turned around within 2 weeks. Let me know if there are any issues with this!

cc @ceresstation

@vince0656
Copy link
Contributor

@PixelantDesign I will try my best and let you know as early as possible if that's not going to be achievable. Currently setting up my local dev environment by first ensuring I can run the site through docker.

@gitcoinbot
Copy link
Member

@vince0656 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vince0656
Copy link
Contributor

I am definitely still working on this. One of the things I'd like to clarify is what style of drop down you'd like for the 'Edit Issue' button. One style is like the sorting drop down on the issue explorer:
image

Would you like this style or was there another style you guys had in mind? Please do include any examples of other styles. Regarding the sorting drop down, would the 'Created: Recent' text make sense in the context of the end goal for this issue? If you are going to end up with a mixture of recently created and re-marketed issues, shouldn't the category be called something like 'Recently marketed' which could apply to both new and re-marketed tickets a like?

Thanks in advance for your help

@vince0656
Copy link
Contributor

Hi there,

Just letting you know that I’m still working on this issue and I’m currently looking at the back-end side of things making modifications to the Bounty model etc

Thanks,
Vincent

@vince0656
Copy link
Contributor

Hi there,

Another update to say that I'm still working on this and may have a working solution. However, I will have to thoroughly test this to be confident.

Thanks,
Vincent

@vince0656
Copy link
Contributor

Hi there,

An update to say that I am confident in my back-end solution but need to write the appropriate unit test(s) for it and then wrap it up by re-ordering the buttons and ensuring the new remarket button is only enabled when the aforementioned conditions are met.

Thanks,
Vincent

@vince0656
Copy link
Contributor

Hi there,

Button is now only enabled under the right conditions. Just working through re-ordering, tests and of course slack integration

Thanks,
Vincent

@vince0656
Copy link
Contributor

As you can see, a pull request has been opened above as the work has been completed. Here are some screenshots from the work:
Screenshot 2019-07-24 at 21 38 55
Screenshot 2019-07-24 at 21 36 51
Screenshot 2019-07-24 at 21 37 03
Screenshot 2019-07-26 at 22 36 09
Screenshot 2019-07-26 at 22 36 35
image

You can see above how the update issue drop down behaves depending on whether the user is allowed to see certain buttons or whether re-marketing is disabled etc.

Any questions, please let me know.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 125.0 DAI (125.0 USD @ $1.0/DAI) has been submitted by:

  1. @vince0656

@ceresstation please take a look at the submitted work:


@thelostone-mc
Copy link
Member

@PixelantDesign Do review the PR submitted ^_^

@vince0656
Copy link
Contributor

@PixelantDesign have you had a chance to look at the PR?

octavioamu added a commit that referenced this issue Aug 14, 2019
#4745: Surface re-marketed issues to the top of the issue explorer
@thelostone-mc
Copy link
Member

@ceresstation Yo this is good for payout ^_^
This is now in live

@vince0656
Copy link
Contributor

Hey @thelostone-mc @ceresstation any idea on when payment will take place?

@vince0656
Copy link
Contributor

Hey @thelostone-mc @ceresstation. Sorry to bug again but any idea on when payment will take place?

1 similar comment
@vince0656
Copy link
Contributor

Hey @thelostone-mc @ceresstation. Sorry to bug again but any idea on when payment will take place?

@owocki
Copy link
Contributor

owocki commented Sep 10, 2019

is there a merged PR somewhere? typically payment happens after a PR is merged

@vince0656
Copy link
Contributor

Hey @owocki, here's the PR that was merged into master: #4876

@owocki
Copy link
Contributor

owocki commented Sep 10, 2019

thanks vincent; @ceresstation looks like this should be good to be paid

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 125.0 DAI (125.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @vince0656.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants