Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover profile failing #4712

Closed
octavioamu opened this issue Jun 28, 2019 · 0 comments · Fixed by #4713
Closed

Popover profile failing #4712

octavioamu opened this issue Jun 28, 2019 · 0 comments · Fixed by #4713
Labels
good first issue This a good first issue for a community newcomer.

Comments

@octavioamu
Copy link
Contributor

octavioamu commented Jun 28, 2019 •
edited
Loading

Describe the bug

Popover profile in this bounty is failing for rafalkowalski because total_earned.toFixed since total_earned is not a Number
https://gitcoin.co/issue/gitcoinco/web/4695/3192
image

To Reproduce

Go to https://gitcoin.co/issue/gitcoinco/web/4695/3192 open console and hover the mouse on rafalkowalski picture.

Expected behavior

Show popover
Screenshots
@octavioamu octavioamu added the good first issue This a good first issue for a community newcomer. label Jun 28, 2019
octavioamu added a commit that referenced this issue Jun 28, 2019
@octavioamu
fix string toFixed #4712
461f013
@octavioamu octavioamu mentioned this issue Jun 28, 2019
Merged
thelostone-mc pushed a commit that referenced this issue Jun 29, 2019
@octavioamu @thelostone-mc
fix string toFixed #4712 (#4713)
5a4f4e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This a good first issue for a community newcomer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix profile popover gitcoinco/web
1 participant
@octavioamu