Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display grant history on profiles before #3859 #4267

Closed
thelostone-mc opened this issue Apr 24, 2019 · 16 comments · Fixed by #4317
Closed

Display grant history on profiles before #3859 #4267

thelostone-mc opened this issue Apr 24, 2019 · 16 comments · Fixed by #4317
Labels
backend This needs backend expertise. Gitcoin Grants Gitcoin Grants

Comments

@thelostone-mc
Copy link
Member

Description

Grant Activity now shows up on the user's profile for newly created grants + subscriptions.
This was introduced in #3859

However the activity before this PR went live also needs to be captured and displayed on the profile (which does not do at the moment)

cc @e18r , @gitcoinco/engineer

@thelostone-mc thelostone-mc added backend This needs backend expertise. Gitcoin Grants Gitcoin Grants labels Apr 24, 2019
@owocki
Copy link
Contributor

owocki commented Apr 24, 2019

@e18r any interest in this one?

@e18r
Copy link
Contributor

e18r commented Apr 26, 2019

@owocki yes, tomorrow will do some research and give you a price

@e18r
Copy link
Contributor

e18r commented Apr 27, 2019

@owocki I'll make a data migration to create Activity objects based on existing Grant and Subscription objects prior to the deployment date of PR #3859. Most info will be accurate, except for multiple grant updates (only the last update can be recovered, whether it's an update or a kill). Price is 1.5 ETH

@owocki
Copy link
Contributor

owocki commented Apr 29, 2019

@e18r sounds good to me. 1.5 ETH is fine

@e18r
Copy link
Contributor

e18r commented Apr 29, 2019

@owocki Great, so how should we proceed? Are you going to create a ticket in Gitcoin, or should we do this informally?

@owocki
Copy link
Contributor

owocki commented Apr 29, 2019

@e18r i can create a bounty if you want. i'm happy to just 🤝 agreement on the 1.5 ETH in exchange for the migration / management command too.

@e18r
Copy link
Contributor

e18r commented Apr 29, 2019

@owocki Let's create the bounty, please. That way it counts towards my reputation.

Management command? What do you mean?

@owocki
Copy link
Contributor

owocki commented Apr 29, 2019

google django management command.

creating a bounty now

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.5 ETH (232.22 USD @ $154.81/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Apr 29, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 10 months, 1 week from now.
Please review their action plans below:

1) e18r has started work.

I'll make a data migration to create Activity objects based on existing Grant and Subscription objects prior to the deployment date of PR #3859. Most info will be accurate, except for multiple grant updates (only the last update can be recovered, whether it's an update or a kill).

Learn more on the Gitcoin Issue Details page.

@e18r
Copy link
Contributor

e18r commented Apr 29, 2019

@owocki @thelostone-mc how can I import grant data to test with? Is this command what I want?

docker-compose exec web python3 app/manage.py sync_geth rinkeby -20 99999999999

@owocki
Copy link
Contributor

owocki commented Apr 29, 2019

hmmm.. that only will import bounties test data unfortunately.

i know that the engineers @danlipert etc are working on providing fixtures. for now the best way is to probably create a grant on your local using rinkeby and go to the admin / update the grant.created_on date to be before the deploy date

e18r pushed a commit to e18r/web that referenced this issue Apr 30, 2019
A data migration is introduced, which generates grant-related activity data
that happened before grant-related activity was recorded.
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.5 ETH (232.83 USD @ $155.22/ETH) has been submitted by:

  1. @e18r

@owocki please take a look at the submitted work:


e18r pushed a commit to e18r/web that referenced this issue May 8, 2019
A data migration is introduced, which generates grant-related activity data
that happened before grant-related activity was recorded.
e18r pushed a commit to e18r/web that referenced this issue May 8, 2019
e18r pushed a commit to e18r/web that referenced this issue May 8, 2019
e18r pushed a commit to e18r/web that referenced this issue May 16, 2019
e18r pushed a commit to e18r/web that referenced this issue May 24, 2019
e18r pushed a commit to e18r/web that referenced this issue May 27, 2019
e18r pushed a commit to e18r/web that referenced this issue May 27, 2019
danlipert added a commit to e18r/web that referenced this issue Jun 3, 2019
danlipert added a commit to e18r/web that referenced this issue Jun 5, 2019
e18r pushed a commit to e18r/web that referenced this issue Jun 19, 2019
2019-06-19: Solved migration conflicts
e18r pushed a commit to e18r/web that referenced this issue Jun 19, 2019
2019-06-19: Solved migration conflicts
danlipert added a commit to e18r/web that referenced this issue Jun 20, 2019
danlipert pushed a commit that referenced this issue Jun 20, 2019
2019-06-19: Solved migration conflicts
@e18r
Copy link
Contributor

e18r commented Jun 24, 2019

@owocki @danlipert @thelostone-mc Please don't forget to mark the issue as "done" on Gitcoin. Thanks.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1.5 ETH (465.33 USD @ $310.22/ETH) attached to this issue has been approved & issued to @e18r.

@e18r
Copy link
Contributor

e18r commented Jun 24, 2019

Thank you. Until next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. Gitcoin Grants Gitcoin Grants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants