Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design - Empty State for kudos on profile page #4191

Closed
MaxStalker opened this issue Apr 12, 2019 · 2 comments · Fixed by #4192
Closed

Design - Empty State for kudos on profile page #4191

MaxStalker opened this issue Apr 12, 2019 · 2 comments · Fixed by #4192
Labels
bug This is something that isn't working as intended. good first issue This a good first issue for a community newcomer.

Comments

@MaxStalker
Copy link
Contributor

MaxStalker commented Apr 12, 2019 •
edited
Loading

Describe the bug
SVG images inside empty kudos state have incorrect text alignment and incorrect font. Besides it doesn't allow option for translation.

To Reproduce
You can check profile page of any user who haven't sent or received kudos (let's say https://gitcoin.co/profile/maxstalker )

Expected behavior
Text inside hex containers is center aligned, font face "Muli" or sans-serif as a fallback

Screenshots
current-profile-kudos

Desktop (please complete the following information):

  • OS: Windows10
  • Browser Chrome
  • Browser Version 73.0.3683.103
@MaxStalker MaxStalker mentioned this issue Apr 12, 2019
Merged
18 tasks
@PixelantDesign
Copy link
Contributor

Thanks @MaxStalker want to help us fix?

@PixelantDesign PixelantDesign added the bug This is something that isn't working as intended. label Apr 16, 2019
@PixelantDesign PixelantDesign added will tip for turnaround good first issue This a good first issue for a community newcomer. labels Apr 16, 2019
@MaxStalker
Copy link
Contributor Author

@PixelantDesign this one is covered in my PR:
#4192

thelostone-mc added a commit that referenced this issue May 13, 2019
@thelostone-mc
Merge pull request #4192 from MaxStalker/design/profile-kudos
465fdae 
Issue #4191 - Profile page empty kudos state
octavioamu added a commit that referenced this issue May 14, 2019
@octavioamu
Revert "Issue #4191 - Profile page empty kudos state"
f7804bb
thelostone-mc added a commit that referenced this issue May 15, 2019
@thelostone-mc
Merge pull request #4392 from gitcoinco/revert-4192-design/profile-kudos
f2c1738 
Revert "Issue #4191 - Profile page empty kudos state"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is something that isn't working as intended. good first issue This a good first issue for a community newcomer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4191 - Profile page empty kudos state MaxStalker/web
2 participants
@PixelantDesign @MaxStalker