Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show left rail radio filters when appropriate #411

Closed
PixelantDesign opened this issue Feb 14, 2018 · 13 comments · Fixed by #486
Closed

Show left rail radio filters when appropriate #411

PixelantDesign opened this issue Feb 14, 2018 · 13 comments · Fixed by #486
Assignees

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Feb 14, 2018

As a user I'd like to see left rail radio filters when applicable, so that I can understand how the navigation effects the content of a page.

Description

Remove left rail filters from the following pages:
Tools
View Profile
Fund Issue

Definition of Done

Left rail removed from above pages.
Build is reviewed with a Gitcoin Core team member @PixelandDesign

@thelostone-mc
Copy link
Member

@PixelantDesign Which means it would turn up on only the explorer page -> which makes sense
In place what do we add there ?
Cause removing the left container entirely on the other pages would make it look odd

@thelostone-mc
Copy link
Member

For anyone who swings by here : helping @PixelantDesign with this ^_^

@gitcoinbot
Copy link
Member

This issue now has a funding of 0.065 ETH (52.06 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $8875.17 more Funded OSS Work Available at: https://gitcoin.co/explorer

@vs77bb
Copy link
Contributor

vs77bb commented Feb 22, 2018

@thelostone-mc: This one is yours (first dibs) :)

@gitcoinbot
Copy link
Member

Work has been started on the 0.065 ETH (52.06 USD) funding by:

  1. @thelostone-mc

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@vs77bb) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

@thelostone-mc
Copy link
Member

thelostone-mc commented Feb 23, 2018

@PixelantDesign looked into this, it's pretty straightforward :)

/toolbox

screenshot-2018-2-23 gitcoin toolbox

/profile

I'm changing the styling just a tad bit on the profile page to make it look better (barely noticeable )
pending merge #323

screenshot-2018-2-23 thelostone-mc gitcoin 1

Note: PS thoughts on this: (the color isn't the best but it sort of looked better than the purple )

screen shot 2018-02-23 at 7 31 34 pm

/funding

screenshot-2018-2-23 gitcoin push open source repos forward 2

Also I'm tempted to refactor the html and maybe fix the css like heading font (similar to #323 ) but I'm guessing I should put that cause we'll be redoing the pages soon?
cc @owocki

thelostone-mc pushed a commit to thelostone-mc/web that referenced this issue Feb 23, 2018
- removed left panel in /profile, /toolbox, /new/funding
- replaces newletter and pushed it to the bottom

Fixes: gitcoinco#411
thelostone-mc pushed a commit to thelostone-mc/web that referenced this issue Feb 23, 2018
- removed left panel in /profile, /toolbox, /new/funding
- replaces newletter and pushed it to the bottom

Fixes: gitcoinco#411
@thelostone-mc
Copy link
Member

thelostone-mc commented Feb 23, 2018

@PixelantDesign can we still keep the metamask status for /funding page as it's relevant.
I'd like to know My metamask status and which network i'm connected to while I'm on this page

If you have thoughts on pushing that up to the navbar or something else, I can add this along with that

/cc: @owocki @mbeacom

@caseyjkey
Copy link

caseyjkey commented Feb 23, 2018 via email

@PixelantDesign
Copy link
Contributor Author

@thelostone-mc Removal of left rail filters looks great!

Let's keep everything else as is for now an open new tickets for additional improvements. I have a new design for the metamask status if you'd like to help me implement :)

@gitcoinbot
Copy link
Member

gitcoinbot commented Feb 25, 2018

The funding of 0.065 ETH (55.55 USD @ $854.54/ETH) attached to this issue has been approved & issued to @thelostone-mc.

@owocki
Copy link
Contributor

owocki commented Feb 26, 2018

@caseykey check the 'mute the thread' option in your github email pls :)

@PixelantDesign did you want to see this coded, or just designed?

@PixelantDesign
Copy link
Contributor Author

@owocki I believe @thelostone-mc has already coded it?

thelostone-mc pushed a commit to thelostone-mc/web that referenced this issue Feb 27, 2018
- removed left panel in /profile, /toolbox, /new/funding
- replaces newletter and pushed it to the bottom

Fixes: gitcoinco#411
@thelostone-mc
Copy link
Member

@vs77bb merged ! ^_^

@gitcoinco gitcoinco deleted a comment May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants