Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Code Coverage by 4% #353

Closed
owocki opened this issue Jan 31, 2018 · 12 comments
Closed

Increase Code Coverage by 4% #353

owocki opened this issue Jan 31, 2018 · 12 comments

Comments

@owocki
Copy link
Contributor

owocki commented Jan 31, 2018

This bounty will be paid out to anyone who meaningfully increases the code coverage of the repository by 4%.

Criteria:

  • You must increase the code coverage (as measured by codecov) of this repo by 4%.
  • You must put (show) some thought into success / failure criteria for each method tested.
  • Please coordinate with other bounty hunters who are working on this bounty so you don't overlap work.
@gitcoinbot
Copy link
Member

This issue now has a funding of 0.055 ETH (61.14 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $12274.5 more Funded OSS Work Available at: https://gitcoin.co/explorer

@gitcoinbot
Copy link
Member

Work has been started on the 0.055 ETH (58.02 USD) funding by:

  1. @tyleryasaka

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

@tyleryasaka
Copy link
Contributor

@owocki This'll be my first time working with this repo, and using codecov for that matter. I've got plenty of experience writing tests so I expect I can figure it out, but I'll post an update if I get stuck on anything.

@mbeacom
Copy link
Contributor

mbeacom commented Feb 2, 2018

@tyleryasaka Thanks for picking this up! Feel free to let me know if you have any questions. Just a note, we're using pytest on Travis.

Looking forward to seeing coverage go up!

@tyleryasaka
Copy link
Contributor

tyleryasaka commented Feb 3, 2018

@mbeacom Thanks! I do have one question. I think you guys might have a team yaml set up for codecov, because when I run it I get a much different number - and I don't see any codecov configurations in the repo. Is there a way I could view the team yaml so I can know what percentage I'm at? 😃

EDIT: I ended up just creating a PR which is the easiest way to get the codecov report. I would still be curious what about the team yaml but it's not necessary.

tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 3, 2018
@tyleryasaka tyleryasaka mentioned this issue Feb 3, 2018
3 tasks
tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 4, 2018
tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 4, 2018
tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 4, 2018
tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 4, 2018
tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 4, 2018
tyleryasaka pushed a commit to tyleryasaka/gitcoinco-web that referenced this issue Feb 4, 2018
@gitcoinbot
Copy link
Member

Work for 0.055 ETH (45.52 USD) has been submitted by @tyleryasaka.

@tyleryasaka, please leave a comment to let the funder (@owocki) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

@tyleryasaka
Copy link
Contributor

@owocki @mbeacom I have an open PR that increases the code coverage by 4.72%.

#375

@owocki
Copy link
Contributor Author

owocki commented Feb 13, 2018

sorry for the radio silence.. i was traveling.. paying out now

@owocki
Copy link
Contributor Author

owocki commented Feb 13, 2018

opening up another PR for this => #408

@tyleryasaka
Copy link
Contributor

@owocki Did you see the PR that was already merged? #375

@owocki
Copy link
Contributor Author

owocki commented Feb 13, 2018

yea... paying out for that now

@gitcoinbot
Copy link
Member

The funding of 0.055 ETH (50.51 USD) attached to this issue has been approved & issued to @tyleryasaka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants