Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as a gitcoin user, i want my grant contributions to show up on my gitcoin profile, becauze i want credit #3316

Closed
owocki opened this issue Dec 26, 2018 · 15 comments · Fixed by #3859
Labels
Gitcoin Grants Gitcoin Grants

Comments

@owocki
Copy link
Contributor

owocki commented Dec 26, 2018

User Story

as a gitcoin user, i want my grant contributions to show up on my gitcoin profile, becauze i want credit

Why Is this Needed

Summary:
because the profile is the catchall summary of what a user has done

Description

Type:
feature

Current Behavior

no grant activity feed items

Expected Behavior

grant activity feed items for 'new subscription', 'new contribution', and 'cancel subscription' on gitcoin profile

Definition of Done

see above ^^

Additional Information

user request:

https://twitter.com/DeanEigenmann/status/1078033355768250370

@owocki owocki added the Gitcoin Grants Gitcoin Grants label Dec 26, 2018
@willsputra
Copy link
Contributor

@owocki is this for My Grants (https://gitcoin.co/grants/profile), or should we put it in the main Gitcoin http://gitcoin.co/profile)?

@thelostone-mc
Copy link
Member

@willsputra should we evaluate making all the products as diff tabs on the profile page ?

I feel the profile is get overloaded.
We could show over all updates of a user across our products .. and to get more details they could scroll down and click on the tabs

Would that make sense?

@willsputra
Copy link
Contributor

@thelostone-mc yea that makes sense! don't want to make the profile too overloaded

@owocki
Copy link
Contributor Author

owocki commented Jan 7, 2019

The main gitcoin.co/profile -- I was just thinking it'd be an activity feed item under 'all activity'

We could show over all updates of a user across our products .. and to get more details they could scroll down and click on the tabs

I like this direction.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.5 ETH (68.38 USD @ $136.75/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Feb 26, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 10 months, 1 week from now.
Please review their action plans below:

1) e18r has started work.

I already set up the development environment and created a test grant. I'm stuck trying to create a grant contribution because of some issue with tokens. In the token dropdown list I have tokens "FOO" and "COLO", which clearly aren't real tokens, so I get the error "The token you selected is not a valid ERC20 token" when I try to submit the grant contribution. Any help appreciated. Thanks!

Learn more on the Gitcoin Issue Details page.

@owocki
Copy link
Contributor Author

owocki commented Feb 26, 2019

@e18r looking fwd to working with you!

@e18r
Copy link
Contributor

e18r commented Feb 26, 2019

Thank you @owocki, any idea how to solve the issue I'm encountering?

@owocki
Copy link
Contributor Author

owocki commented Feb 26, 2019

@e18r those are rinkeby tokens. you can add a new token to the list by adding a new economy.Token, or you can switch to mainnet or another network.

note that if you add new tokens that retail.views.tokens is cached so you ll have to bust that cache to make them show up.

e18r pushed a commit to e18r/web that referenced this issue Feb 27, 2019
When a user subscribes/contributes to a grant, or when she unsubscribes,
the event is recorded as a new Activity object. In order to accomplish
this, a new foreign key was added to the Activity object, which references
the grant subscriptions object. I experienced a few crashes after
implementing this change, although I'm not sure they're related.
e18r pushed a commit to e18r/web that referenced this issue Mar 7, 2019
The grant subscriptions, contributions and cancellations are showing up on the user's profile.
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.5 ETH (68.82 USD @ $137.64/ETH) has been submitted by:

  1. @e18r

@owocki please take a look at the submitted work:


e18r pushed a commit to e18r/web that referenced this issue Mar 8, 2019
* Included migration file for new column in dashboard.models.Activity
* Refactored the activity creation code into a helper method
e18r pushed a commit to e18r/web that referenced this issue Mar 10, 2019
* Removed unrelated database modifications from migration file
e18r pushed a commit to e18r/web that referenced this issue Mar 13, 2019
* Grant activities include a metadata object with generic info
* The metadata object includes a new field, 'category', which allows
  to identify different supersets of activity types (bounties, kudos,
  grants)
* A backwards-compatible differentiation of category types was
  introduced in Activity.view_props
* New icons were established and visual items rearranged so that
  grant activity items appear nicely in /activity
e18r pushed a commit to e18r/web that referenced this issue Mar 13, 2019
Changed the class name from 'far' to 'fa' (Font Awesome). This
increments the available icons and allows currently used icons to be
more creative.
e18r pushed a commit to e18r/web that referenced this issue Mar 13, 2019
Record activities related with the grant lifecycle -- new_grant,
update_grant, killed_grant
e18r pushed a commit to e18r/web that referenced this issue Mar 13, 2019
* Updated the Profile model to include grant lifecycle activities
* Created the corresponding tab names in the Profile view
* Created a new template to show the new activities
* Included the template in the profile_activities template
e18r pushed a commit to e18r/web that referenced this issue Mar 13, 2019
* Added icons for each activity type in the Activity model
* Modified the metadata of grant activities so that it can be
  displayed correctly
* Adapted the activity template so it shows the grant information
  correctly
* Corrected spelling of "cancelled"
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of this issue was increased to 1.0 ETH (131.81 USD @ $131.81/ETH) .

e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
When a user subscribes/contributes to a grant, or when she unsubscribes,
the event is recorded as a new Activity object. In order to accomplish
this, a new foreign key was added to the Activity object, which references
the grant subscriptions object. I experienced a few crashes after
implementing this change, although I'm not sure they're related.
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
The grant subscriptions, contributions and cancellations are showing up on the user's profile.
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
* Included migration file for new column in dashboard.models.Activity
* Refactored the activity creation code into a helper method
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
* Removed unrelated database modifications from migration file
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
* Grant activities include a metadata object with generic info
* The metadata object includes a new field, 'category', which allows
  to identify different supersets of activity types (bounties, kudos,
  grants)
* A backwards-compatible differentiation of category types was
  introduced in Activity.view_props
* New icons were established and visual items rearranged so that
  grant activity items appear nicely in /activity
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
Changed the class name from 'far' to 'fa' (Font Awesome). This
increments the available icons and allows currently used icons to be
more creative.
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
Record activities related with the grant lifecycle -- new_grant,
update_grant, killed_grant
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
* Updated the Profile model to include grant lifecycle activities
* Created the corresponding tab names in the Profile view
* Created a new template to show the new activities
* Included the template in the profile_activities template
e18r pushed a commit to e18r/web that referenced this issue Mar 15, 2019
* Added icons for each activity type in the Activity model
* Modified the metadata of grant activities so that it can be
  displayed correctly
* Adapted the activity template so it shows the grant information
  correctly
* Corrected spelling of "cancelled"
e18r pushed a commit to e18r/web that referenced this issue Mar 19, 2019
* Solve migration conflicts
* Fix indentation flaws
e18r pushed a commit to e18r/web that referenced this issue Mar 24, 2019
…co#3316)

Changed the class name back to `far`. I thought it was a bug but I was mistaken.
e18r pushed a commit to e18r/web that referenced this issue Apr 18, 2019
danlipert added a commit that referenced this issue Apr 24, 2019
Grant contributions in profile (#3316)
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1.0 ETH (163.58 USD @ $163.58/ETH) attached to this issue has been approved & issued to @e18r.

@dconroy
Copy link
Contributor

dconroy commented May 30, 2019

@owocki is this still considered done? I dont see grant contributions on profiles currently.

@owocki
Copy link
Contributor Author

owocki commented May 30, 2019

@e18r could advise.. but i think we need to merge and run #4317 to get legacy grant contribs showing on the profile

@e18r
Copy link
Contributor

e18r commented May 30, 2019

@dconroy @owocki That's exactly right. Grant-related activity (when you create, update, cancel, contribute to, subscribe to, or unsubscribe from a grant) that has taken place after 2019-04-24 shows up immediately on your profile. Older grant-related activity will show up as soon as the data migration of PR #4317 is executed against the production database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Grants Gitcoin Grants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants