Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an admin, I want to be notified if a funder funds a bounty with an extremely low price because setting reasonable and fair hourly rates is one of many ways that OSS is sustained. #2808

Closed
frankchen07 opened this issue Nov 13, 2018 · 35 comments · Fixed by #3219
Labels
Gitcoin Emails Gitcoin Emails Gitcoin Internal Tool Gitcoin Internal Tool

Comments

@frankchen07
Copy link
Contributor

frankchen07 commented Nov 13, 2018

User Story

As an admin, I want to be notified if a funder funds a bounty with an extremely low price because setting reasonable and fair hourly rates is one of many ways that OSS is sustained.

Why Is this Needed

OSS sustainability is only possible if we pay developers a fair price for the value they put forth. Certain prices (e.g < $1) for any type of task is considered lowballing the developer / bounty hunter. Warning Gitcoin admins of an extremely low bounty price and giving the admins the option to manually follow up with the funder is necessary to prevent publishing of lowball bounties.

Current Behavior

Currently, there are no warnings or emails triggered when a bounty is funded below a certain threshold.

Expected Behavior

An email is automatically sent to Gitcoin administrators when a bounty is funded that is below $X.

Definition of Done

  1. When a funder hits "submit an issue," a threshold check (if else logic) on the bounty value is performed.
  2. If the bounty value is below the threshold, an automatic email to Gitcoin admins is triggered with the issue link, funder, and funder information.
  3. Being below a $X threshold should not prevent the bounty from being published, but an automatic email should be triggered.
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.25 ETH (52.61 USD @ $210.44/ETH) attached to it as part of the Gitcoin fund.

@gitcoinbot
Copy link
Member

gitcoinbot commented Nov 14, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 9 months, 1 week from now.
Please review their action plans below:

1) linosorice has applied to start work (Funders only: approve worker | reject worker).

This is my first issue.
In order to complete the task I'll setup the environment with docker (https://docs.gitcoin.co/mk_setup/) then I'll put the threshold logic inside the function that handle the "submit an issue" button. After that I test the code locally.
2) girards has applied to start work (Funders only: approve worker | reject worker).

Even though I haven't done webApp in Python before I've already looked at the code and have a pretty good idea of what needs to be done. The check needs to be done in the bounty_request/views.py
3) oddballbutler has been approved to start work.

This would be my first issue.

I already have a Docker Build running locally.

I imagine I'll use marketing.mails.send_mail()

I'm wondering: How should I determine what the price threshold should be?

Learn more on the Gitcoin Issue Details page.

@kuhnchris
Copy link
Contributor

Additionally I may also want to point, that we could include a "The average hourly rate on the platform currently is 0.XXX ETH per hour" when creating a bounty, and alert the user if his price (per estimated h) is lower than the 'platform average'. (just as an idea)

@frankchen07
Copy link
Contributor Author

@usmanmuhd - since you were the first, I've approved you for work!

@kuhnchris - there are actually two tickets open to improve pricing:

#2158
#2117

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@usmanmuhd
Copy link
Contributor

Will be sending in a WIP PR by today

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@usmanmuhd
Copy link
Contributor

Will be freeing up the bounty for some other bounty hunter. Keeping very busy with assignments and assessments

@kuhnchris
Copy link
Contributor

Did you do any work or shall we create from scratch?

@usmanmuhd
Copy link
Contributor

I did not do much except a very basic HTML page. So yeah, it should be from scratch.

@kuhnchris
Copy link
Contributor

kuhnchris commented Nov 27, 2018

OK, thank you. Mind "Stop Work" on Gitcoin?

@usmanmuhd
Copy link
Contributor

I did that already.

@gitcoinbot
Copy link
Member

@FrederikBolding Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@FrederikBolding
Copy link
Contributor

Sorry, I wasn't aware that I had this issue. I've stopped work as I'm busy with another issue 😄

@oddballbutler
Copy link
Contributor

oddballbutler commented Dec 11, 2018

@frankchen07 So I'm thinking the change should go in dashboard.helpers.process_bounty_changes(). Did you have any idea about how the low bounty threshold value should be generated?

@oddballbutler
Copy link
Contributor

Also, should I send the email to [email protected]? Or something else?

@kuhnchris
Copy link
Contributor

@PixelantDesign @frankchen07 any infos for oddballbutler?

@oddballbutler
Copy link
Contributor

So I'm seeing that danlipert already has a pull request for this... I wasn't aware that someone else was working on this when I applied for the issue on gitcoin. Is there a way around this kind of problem?

@frankchen07
Copy link
Contributor Author

frankchen07 commented Dec 13, 2018

I'd say the low bounty threshold can be hardcoded @ $10 for now, given if something is priced at that, the highest going hourly rate would be $10/hr, which is quite low. So < $10, and the email would be triggered.

@kuhnchris
Copy link
Contributor

@frankchen07 that depends tho! what if the bounty was made at a time when ETH was at a all time high (300$+), a bounty with .3 eth = 30$, with today's price that'd be less than 8$. Would that notification run daily and consider the current prices or shall that be a one time run?

oddballbutler added a commit to oddballbutler/web that referenced this issue Dec 14, 2018
@frankchen07
Copy link
Contributor Author

@kuhnchris - that's an excellent point. Thanks for bringing it up.

I'd trend towards not over-engineering this for now, and use the USD value at the time the bounty was created.

Your point about the volatility of ETH is spot on, but I'm more concerned with lowballers at the onset of bounty creation, rather than normal bounties that "turn into" lowballs simply due to market volatility. The former is a condition of the funder, whereas the second, is the market.

@kuhnchris
Copy link
Contributor

That's true. The first one can be actively influenced, the second one is whale-pending on the price.
So it makes sense to inform the user during creation/relatively early in the process about the low-balls price.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.25 ETH (21.1 USD @ $84.39/ETH) has been submitted by:

  1. @oddballbutler

@frankchen07 please take a look at the submitted work:


@rmshea
Copy link
Contributor

rmshea commented Jan 15, 2019

Hey @frankchen07, looks like this one is ready to be reviewed!

@frankchen07
Copy link
Contributor Author

thanks - will try my best to build this into the next sprint, get it merged, and get @oddballbutler paid out. Thank for being patient, lots of moving pieces.

@oddballbutler
Copy link
Contributor

@frankchen07 Just got an email saying that the gitcoin issue expires in two days? Was this ever taken care of? I would like to be paid for my work...

@PixelantDesign
Copy link
Contributor

We will get this reviewed. Sorry for the delay.

@kuhnchris
Copy link
Contributor

Hey there @oddballbutler - seems like the team is currently in event-travel mode. I added a couple of question and one review point in the PR, please check them and get back to us, if that's fine I think we can go ahead and merge that change in.

Thanks!
Chris

@owocki
Copy link
Contributor

owocki commented May 21, 2019

@danlipert @PixelantDesign can we pls get this reviewed? thanks

@oddballbutler
Copy link
Contributor

@kuhnchris ok thanks. I won't be able to work on it for a few weeks though.

@kuhnchris
Copy link
Contributor

kuhnchris commented May 23, 2019

It depends on how fast @owocki and co needs it, if it's just regarding the settings move we can do it as well, if it's suddently urgent. else, we'd wait, i guess. :-)

oddballbutler added a commit to oddballbutler/web that referenced this issue Jun 21, 2019
oddballbutler added a commit to oddballbutler/web that referenced this issue Jun 24, 2019
oddballbutler added a commit to oddballbutler/web that referenced this issue Jun 24, 2019
oddballbutler added a commit to oddballbutler/web that referenced this issue Jun 24, 2019
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.00750 ETH (1.41 USD @ $188.01/ETH) has been granted to @oddballbutler for this issue from @frankchen07. ⚡️

Nice work @oddballbutler! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.25 ETH (47.0 USD @ $188.01/ETH) attached to this issue has been approved & issued to @oddballbutler.

Additional Tips for this Bounty:

  • frankchen07 tipped 0.0075 ETH worth 1.41 USD to oddballbutler.

@sirlupinwatson
Copy link

Congrats @frankchen07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Emails Gitcoin Emails Gitcoin Internal Tool Gitcoin Internal Tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants