20181113 -- Grants QA on Weekly Grants Team Call

[owocki]

holistically:

• black tophat does not show up across the site, and also the nav is the bounties nav
• we should have a link to quickstart in the top nav

grants detail page:

• on grants view, what to do about update posting?

fund a grant view:

• on funding view, create view, cancel view, add eip 1102 support
• new default image
• remove ETH as an option for this (and maybe enable WETH)
• Token Approval Limit - [ ] Alisa has a ticket for this ... Maybe we can make it a hidden var and approve for 99999?
• on payment period in the fund view, shouldnt have 'any', and we should probably remove 'minute' and 'hours'.
• MetaTx Gas Price in Payment Token - [ ] provide some sort of sane default here
• BN.js issue on fund grant page http://bits.owocki.com/248bb1236b9f/Screen%20Shot%202018-11-13%20at%2010.54.50%20AM.png
• unfurl image / title / desc should use the grant logo.

index page:

• grants search does not work, 'search' button is missing.. (in PR and ready for review)
• show NUM subscriptoins on the card
• if you click on any part of the card you are taken to the grant

my grants

• tx history is hardcoded
• ui is clunky on the 'i have no grants' -- [ ] can we co-opt the 'no bounty' imagery here?

create a grant

• get rid of total amount, focus on monthly amount

• make funding targets in DAI, not in ETH. or better yet, allow them to choose which token their targets are in.

• Required subscription amount in ETH / Required Token For Subscription --> for now, lets hardcode this to zero and then re-enable IFF people demand.

• down the line: figure out how to handle the attack vector where user can set a very low ETH amount.

• Admin Wallet Address => Recipient Wallet Address

• Frequency of payments => abstract it away for now, just like 'required subscription amount and required token'

• grants admin page, QAing
  https://grants.gitcoin.co/grants/5

• logo dimensions -- [ ] they should be able to adjust what is centered or we should provide guidelines on dimensions. perhaps kevins janky CSS can help: https://gist.github.com/gitcointestuser2/2b471dc47fbc0eeca9452fc49074259e

• just one save button is sufficient

grant milestone page

• we need a 'back button'
• complete / delete buttons need color http://bits.owocki.com/014ebc0c64b0/Screen%20Shot%202018-11-13%20at%2011.14.03%20AM.png
• information architecture of 'create milestone' and current milestones -- [ ] figure out where current milestones go (shouldnt be under 'create milestones')
• when you complete a milestone, an activity/update should show up

TODO: QA emails
TODO: QA cancel grant
TODO: QA cancel contributions page

[owocki]

other QA tickets
#2753
#2798

[captnseagraves]

@PixelantDesign Can you share the new default image you would like to use for grants?

[captnseagraves]

Another QA Issue here: #2862 (comment)

[thelostone-mc]

Open issues are captured here #2949