Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "What to Know" section (Auto-Approve) #2772

Closed
4 tasks done
kuhnchris opened this issue Nov 12, 2018 · 3 comments
Closed
4 tasks done

Update "What to Know" section (Auto-Approve) #2772

kuhnchris opened this issue Nov 12, 2018 · 3 comments
Assignees
Labels
bug This is something that isn't working as intended.

Comments

@kuhnchris
Copy link
Contributor

kuhnchris commented Nov 12, 2018

Why Is this Needed

image

KuhnChris [9 hours ago]
does the system really currently do that..?
mbeacom [4 hours ago]
By default, yes. We recently merged a PR that allows the funder to disable this outright, though.
owocki [3 minutes ago]
hmm should we update the copy here? @pixelant [Gitcoin]
Pixelant [Gitcoin] [2 minutes ago]
yes we should def update that copy. i'll capture on a ticket

Definition of Done

  • Remove auto approve icon
  • Add the following copy:
    A funder may override the auto approve setting. In the case, workers will not be automatically approved after 72 hours.
  • Check other how it works pages and update this info on other pages.
  • Review the changes with a Gitcoin core team member
@PixelantDesign PixelantDesign added bug This is something that isn't working as intended. priority: ungroomed labels Nov 12, 2018
@PixelantDesign
Copy link
Contributor

Thanks @kuhnchris !

@kuhnchris
Copy link
Contributor Author

Hey there @PixelantDesign
Quick check on the source:

➜  app git:(master) ✗ grep "72 hours" * -r
dashboard/templates/shared/issue_details.html:      {% trans "Worker will be auto-approved after 72 hours." %}
locale/zh_Hant/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/zh_Hant/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/zh_Hant/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/zh_Hant/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/pl/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/pl/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/pl/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/zh_Hans/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/zh_Hans/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/zh_Hans/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/zh_Hans/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/es/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/es/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/es/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/es/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/hi/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/hi/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/hi/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/hi/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/de/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/de/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/de/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/de/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/ja/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/ja/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/ja/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/ja/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/ko/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/ko/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/ko/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/ko/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
locale/it/LC_MESSAGES/django.po:"As a reminder, after 72 hours any contributor will be auto-approved and can "
locale/it/LC_MESSAGES/django.po:"          approve the contributor after 72 hours. \n"
locale/it/LC_MESSAGES/django.mo:          approve the contributor after 72 hours.
locale/it/LC_MESSAGES/django.mo:As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue.
retail/templates/emails/start_work_new_applicant.html:    {% trans "As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue." %}
retail/templates/emails/start_work_new_applicant.txt:{% trans "As a reminder, after 72 hours any contributor will be auto-approved and can automatically submit a PR against your issue." %}
retail/templates/how_it_works/permissions.html:          approve the contributor after 72 hours.
retail/templates/how_it_works/permissions.html:   workers will not be automatically approved after 72 hours.</p>

Should the same copy apply to the other texts aswell? (emails->start work new applicant, issue_details)

Thanks!

@thelostone-mc
Copy link
Member

thelostone-mc commented Nov 13, 2018

I think it should be left on details cause that's essentially this 🤔
which I believe we allow at the moment

@PixelantDesign lemme know if that's not the case

screen shot 2018-11-13 at 2 24 40 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

No branches or pull requests

3 participants