Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard bounties: multiple bounties per issue URL #251

Closed
owocki opened this issue Jan 16, 2018 · 5 comments
Closed

standard bounties: multiple bounties per issue URL #251

owocki opened this issue Jan 16, 2018 · 5 comments
Assignees
Labels
bounties bug This is something that isn't working as intended.

Comments

@owocki
Copy link
Contributor

owocki commented Jan 16, 2018

how do we want to handle multiple bounties per github issue URL?

right now, via the current stdbounties UI... someone can submit mulitiple bounties on the same GH URL. this is confusing because while standardbounties supports it.. the gitcoin UI does not..

maybe we add a validation step if someone tries to enter a currently active bounty into funding/new, we tell them they can't (or solicit them adding funds to the bounty instead?)..

@jasonrhaas
Copy link
Contributor

Right now once an issue is in the fulfilled state in Gitcoin, it doesn't allow people to add another fulfillment via the bounty details page. I believe this can be manually overridden by going to the /fulfill page directly.

image

Currently it adds the latest bounty to the stack on the Blockchain, and the "Acceptance" part just takes the latest one. It's non ideal but I was trying to go for somewhat parity features at first.

We can display in the UI somewhere that the bounty has been fulfilled by "John Smith" or whatever. I think with the Oauth stuff that was added we can pull the Github Email Address.

I think the best solution is to just display the multiple bounties that have been submitted right in the webpage. This requires an update to the database schema though, so this would require a migration so we have to be careful about how we do it.

@owocki
Copy link
Contributor Author

owocki commented Jan 17, 2018

i wasn't talking about multiple fulfillments per bounty... i was talking about multiple bounties per github issue.

might be easier to just chat about this on the phone?

@jasonrhaas
Copy link
Contributor

Ah yes, I read that wrong. Correct, should be a check in there to kick back if the github issue already exists. That should be an easy fix.

@jasonrhaas
Copy link
Contributor

jasonrhaas commented Jan 17, 2018

Ok so now before kicking off the process it checks that database to see if that issue is already in there. If it is, it pops up a banner. We can probably do more in the future but I believe this is feature parity for the moment.

image

@jasonrhaas
Copy link
Contributor

a2cf8c5

@jasonrhaas jasonrhaas self-assigned this Jan 17, 2018
@jasonrhaas jasonrhaas added the bug This is something that isn't working as intended. label Jan 17, 2018
@owocki owocki closed this as completed Mar 19, 2018
thelostone-mc pushed a commit that referenced this issue May 24, 2021
untested as i can not test nothing nowhere!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounties bug This is something that isn't working as intended.
Projects
None yet
Development

No branches or pull requests

3 participants