Clicking Stop Work Did Not Stop Work

[PixelantDesign]

Describe the bug
@darkdarkdragon clicked stop work on an issue, and work was not stopped, or Gitcoin Bot did not log the stop action on the Github thread.

This is the issue:
#1769 (comment)

[mbeacom]

@PixelantDesign Can you start moving these bug issues into the Triage Bugs project and labeling them with the bug label so we can track them on the bug board?

[darkdarkdragon]

I've clicked 'stop work', got notification 'Thanks for letting us know', so I've assumed it was stopped.
But later I've found out that it wasn't stopped.

[PixelantDesign]

@mbeacom done

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.1 ETH (27.76 USD @ $277.56/ETH) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $19,062.15 more funded OSS Work available on the Gitcoin Issue Explorer

[pinkiebell]

Maybe we shouldn't show a success banner before we have the result from the api? 😄
We should show a 'please hold the line'/ visual feedback animation instead,
until we actually get the api results. 👍

[pinkiebell]

Something like that, maybe ? @PixelantDesign

[owocki]

i like this visually

[pinkiebell]

@darkdarkdragon
Did you immediately closed the window after reading the notification?
Or better q: Did you seen two of these ''Thanks for letting us know..'?

[darkdarkdragon]

@pinkiebell I don't remember, it was some time ago. Probably yes, I've closed window right after seeing 'thanks...'

[PixelantDesign]

@pinkiebell
If I remember correctly, Gitcoin Bot did not comment on the ticket when @darkdarkdragon clicked Stop Work.

I think the green confirmation works as a cute to let users know that work has been stopped...but I'm not sure we need the big glow.

[pinkiebell]

@PixelantDesign
The issue the way I see it is the following:
On start/stop work; (after submit) we display the green banner before we even make the API calls.
I think this is because of good faith and to have immediate UI feedback.
However, if the user now closes the tab/window it might happen that the request was still pending/not done.

This is a user experience issue, if I understand correctly.
I may also be completely wrong 😆

[thelostone-mc]

@pinkiebell Ah yeah that's on me!
The success banner should turn up only after getting a successful response from the API.
The waiting screen does seem to fix that

@PixelantDesign without the color it looks like this:

It looks dull ! the blue looks too bright but it's subtle so I'm in 2 minds

[PixelantDesign]

Thanks for looking at this @thelostone-mc @pinkiebell
Could we try this color #3E00FF with a 30% opacity behind the animated helmet?

[thelostone-mc]

Not sure which one you meant by this is how it would look

[PixelantDesign]

Would it start with the top one and then fade out? Hopefully this doesn't stay up long, ya?

[thelostone-mc]

@PixelantDesign mind throwing in a design to make things clearer ?
Merging it now -> and i'll update it once I see the design ^_^

[pinkiebell]

@thelostone-mc @PixelantDesign
please try with: rgb(11,220,230) as box-shadow color 👍

showBusyOverlay();document.querySelector('.busyOverlay').style['box-shadow']='0 0 100em 0 inset rgb(11,220,230)'

[thelostone-mc]

Deferring it to @PixelantDesign ! closing this out for now ^_^

[PixelantDesign]

@pinkiebell could you click start work and submit work on this so that we can pay you?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 11 months, 4 weeks from now.
Please review their action plans below:

1. pinkiebell has started work.

   (* *)
   /.\
   (/ )
   (_ _)

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.1 ETH (27.82 USD @ $278.22/ETH) has been submitted by:

1. @pinkiebell

@owocki please take a look at the submitted work:

• (Link Not Provided) by @pinkiebell

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $20,829.18 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 0.1 ETH (27.82 USD @ $278.22/ETH) attached to this issue has been approved & issued to @pinkiebell.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $20,801.36 more funded OSS Work available on the Gitcoin Issue Explorer