Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back Button on Contributor Ftux Not Working #1685

Closed
PixelantDesign opened this issue Jul 11, 2018 · 7 comments · Fixed by #1788
Closed

Back Button on Contributor Ftux Not Working #1685

PixelantDesign opened this issue Jul 11, 2018 · 7 comments · Fixed by #1788
Labels
bug This is something that isn't working as intended.

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Jul 11, 2018

Once a Contributor starts the flow, they should be able to click the back button to go back to the landing page that they came from.

https://gitcoin.co/onboard/contributor/

To Reproduce

  1. Go to https://gitcoin.co/onboard/contributor/
  2. Try to click the back button to get back to the landing page.

Expected behavior

User should be able to go back.

@PixelantDesign PixelantDesign added this to the July 2018 milestone Jul 11, 2018
@PixelantDesign PixelantDesign added the bug This is something that isn't working as intended. label Jul 11, 2018
@owocki
Copy link
Contributor

owocki commented Jul 11, 2018

i brought this up more than once during QA of the initial release.

@thelostone-mc
Copy link
Member

Could you describe when this happens ?
I can't seem to get it at my end

screenshot_20180714-200649

mttmartin added a commit to mttmartin/web that referenced this issue Jul 15, 2018
…tton take them back to their previous location.

Fixes: gitcoinco#1685
@mttmartin
Copy link
Contributor

I just pushed a commit (mttmartin@7453db9) which might fix this specific bug depending its definition.

@PixelantDesign, here are my assumptions regarding the bug as I've understood you:

Current behavior:

  1. User gets pointed to https://gitcoin.co/onboard/contributor/
  2. When user clicks back button once: they are still on contributor onboard page, possibly feeling trapped
  3. If user clicks a second time: they are returned to their original location

If this is the case, my changes should fix this.

Here is another issue I see with this, and it might be what you are referring to. The browser back/forward buttons have unintuitive behavior on the onboard page, because their actions differ from the Next/Previous buttons on same page(i.e. they do nothing). Here's an example use-case:

  1. Land on contributor onboard page
  2. Click Next a couple times
  3. User decides they would like to go back to the previous page/step
  4. Hit browser back button
  5. Page does not change(unless they hit back enough times they hit whatever page in their history that they were on before the contributor onboard)

@SaptakS
Copy link
Contributor

SaptakS commented Jul 18, 2018

@mttmartin I think your commit looks good towards solving this issue. Can you please raise a PR?

@PixelantDesign
Copy link
Contributor Author

Thank you @mttmartin!

where ever user comes from clicking back button should take the user back to the previous page (to avoid trapped feeling).

@PixelantDesign
Copy link
Contributor Author

To receive a tip please update the July bug list with your PR, once the task is complete. Thanks!

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.04000 ETH (19.27 USD @ $481.66/ETH) has been granted to @mttmartin for this issue from PixelantDesign. ⚡️

The sender had the following public comments:

Thanks for your help!

Nice work @mttmartin! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants