-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back Button on Contributor Ftux Not Working #1685
Comments
i brought this up more than once during QA of the initial release. |
…tton take them back to their previous location. Fixes: gitcoinco#1685
I just pushed a commit (mttmartin@7453db9) which might fix this specific bug depending its definition. @PixelantDesign, here are my assumptions regarding the bug as I've understood you: Current behavior:
If this is the case, my changes should fix this. Here is another issue I see with this, and it might be what you are referring to. The browser back/forward buttons have unintuitive behavior on the onboard page, because their actions differ from the Next/Previous buttons on same page(i.e. they do nothing). Here's an example use-case:
|
@mttmartin I think your commit looks good towards solving this issue. Can you please raise a PR? |
Thank you @mttmartin! where ever user comes from clicking back button should take the user back to the previous page (to avoid trapped feeling). |
To receive a tip please update the July bug list with your PR, once the task is complete. Thanks! |
⚡️ A tip worth 0.04000 ETH (19.27 USD @ $481.66/ETH) has been granted to @mttmartin for this issue from PixelantDesign. ⚡️ The sender had the following public comments:
Nice work @mttmartin! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.
|
Once a Contributor starts the flow, they should be able to click the back button to go back to the landing page that they came from.
https://gitcoin.co/onboard/contributor/
To Reproduce
Expected behavior
User should be able to go back.
The text was updated successfully, but these errors were encountered: