Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avatar bug -- wrong eye color #1543

Closed
owocki opened this issue Jun 26, 2018 · 5 comments
Closed

avatar bug -- wrong eye color #1543

owocki opened this issue Jun 26, 2018 · 5 comments
Labels
bug This is something that isn't working as intended.

Comments

@owocki
Copy link
Contributor

owocki commented Jun 26, 2018 •
edited
Loading

http://bits.owocki.com/302n3W2o0Y0u/Screen%20Shot%202018-06-25%20at%208.12.03%20PM.png
https://gitcoin.co/profile/owocki
https://s3.us-west-2.amazonaws.com/gitcoin-storage-fz4cb2/avatars/406d684cc7f4e35b2ebb083c0634fc9d/owocki.svg

the eyes on this avatar are white, they should be dark if the users skin color is light and visa versa
@thelostone-mc thelostone-mc added the bug This is something that isn't working as intended. label Jun 26, 2018
@thelostone-mc
Copy link
Member

Yeah me and @mbeacom did come across this ! Happens only when glasses are added to the avatar.

@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

is it a bounty-able bug?

Related: Should we rip out the avatar builder frontend so we DRY (wrt the frontend vs backend implementation)?

@thelostone-mc
Copy link
Member

@mbeacom @SaptakS wanna get this done this week ?

@PixelantDesign PixelantDesign added this to the July 2018 milestone Jul 5, 2018
@PixelantDesign PixelantDesign mentioned this issue Jul 11, 2018
Closed
21 tasks
@PixelantDesign PixelantDesign removed this from the July 2018 milestone Jul 20, 2018
@PixelantDesign PixelantDesign mentioned this issue Aug 3, 2018
Closed
19 tasks
@octavioamu
Copy link
Contributor

octavioamu commented Aug 9, 2018 •
edited
Loading

A way to solve this could be just don't use the class '.st1' for the glasses so the eyes with the same class are not overwritten. Change the class name works?

thelostone-mc added a commit to thelostone-mc/web that referenced this issue Sep 4, 2018
@thelostone-mc
avatar: fixed glasses & eyes same color issues
15a7605 
Fixes: gitcoinco#1543
@thelostone-mc thelostone-mc mentioned this issue Sep 4, 2018
Merged
@thelostone-mc
Copy link
Member

screen shot 2018-09-04 at 9 05 58 pm

@SaptakS SaptakS closed this as completed in 52af836 Sep 5, 2018
@SaptakS SaptakS removed the to do label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is something that isn't working as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@PixelantDesign @owocki @octavioamu @thelostone-mc @SaptakS