Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Dibs' from Gitcoin Bot comment on Github #1535

Closed
vs77bb opened this issue Jun 25, 2018 · 5 comments
Closed

Remove 'Dibs' from Gitcoin Bot comment on Github #1535

vs77bb opened this issue Jun 25, 2018 · 5 comments
Assignees

Comments

@vs77bb
Copy link
Contributor

vs77bb commented Jun 25, 2018

User Story

As a funder, I'd like to remove all reference to 'dibs' in approve only bounties where work is started by approval.

Why Is this Needed?

Summary:
screen shot 2018-06-24 at 10 43 49 pm

Description

Type: Bug

Current Behavior

Currently, the first person on an 'approved' bounty still sees '1st dibs', which isn't the case in this setting.

Expected Behavior

Remove 1st dibs, 2nd dibs, etc. from the wording in this scenario.

@vs77bb
Copy link
Contributor Author

vs77bb commented Aug 31, 2018

@thelostone-mc @SaptakS Just added this to triage, this would be a quick win if we can remove this language soon, still causes confusion to have 'dibs' written when it's really approval-only now (and the first person does not have dibs).

thelostone-mc added a commit to thelostone-mc/web that referenced this issue Sep 1, 2018
@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 1, 2018

@vs77bb from the code what I see is that dibs work is used only for co-op bounties.
Could you double confirm that ?

I have a PR out for this at #2138 -> will merge after you confirm on this :)

@thelostone-mc thelostone-mc self-assigned this Sep 1, 2018
thelostone-mc added a commit to thelostone-mc/web that referenced this issue Sep 1, 2018
@vs77bb
Copy link
Contributor Author

vs77bb commented Sep 6, 2018

@thelostone-mc This is not the case... here's a regular bounty where it's showing up.

screen shot 2018-09-06 at 8 44 44 am

@vs77bb
Copy link
Contributor Author

vs77bb commented Sep 6, 2018

Even for 'Co-op' bounties, I don't think 'dibs' makes much sense anymore... really think it can be removed everywhere

@mbeacom
Copy link
Contributor

mbeacom commented Sep 6, 2018

@vs77bb Do you want dibs removed from ALL gitcoin comments then (including project type traditional / permission type permissionless)?

mbeacom pushed a commit that referenced this issue Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants