Merge pull request #5496 from thelostone-mc/bug

bug: fixed wonky button
gitcoinco · Nov 14, 2019 · aa2c138 · aa2c138
2 parents a4b0537 + b43f906
commit aa2c138
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 30 deletions.
diff --git a/app/assets/v2/css/bounty.css b/app/assets/v2/css/bounty.css
@@ -410,16 +410,6 @@ a.btn {
   margin-left: 5px;
 }
 
-#btn-white .github-comment {
-  color: #FFFFFF;
-  position: absolute;
-  font-size: 0.625rem;
-  text-align: center;
-  width: 1.25rem;
-  top: 0.4375rem;
-  right: 0.5rem;
-}
-
 .activity {
   margin-bottom: 10px;
 }

diff --git a/app/assets/v2/images/comment.svg b/app/assets/v2/images/comment.svg
diff --git a/app/assets/v2/js/pages/bounty_details.js b/app/assets/v2/js/pages/bounty_details.js
@@ -1247,9 +1247,7 @@ var do_actions = function(result) {
       text: (result['repo_type'] === 'private' ? '<i class="fas fa-lock mr-2"></i> ' +
         gettext('Private Repo') : '<i class="fab fa-github mr-2"></i>' + gettext('View On Github')),
       parent: 'github_actions',
-      title: gettext('View issue details and comments on Github'),
-      comments: result['github_comments'],
-      color: 'comments'
+      title: gettext('View issue details and comments on Github')
     };
 
     actions.push(_entry);

diff --git a/app/dashboard/templates/bounty/details.html b/app/dashboard/templates/bounty/details.html
@@ -262,22 +262,6 @@ <h5 class="bounty-heading">{% trans "Funder" %}</h5>
           <a class="button button--primary accept [[if !enabled]]disabled[[/if]]" role="button" href="[[:href]]" target="[[:target]]">
             <span class="font-caption">[[:text]] ( [[:pending_acceptance]] )</span>
           </a>
-        [[else color == 'comments']]
-          <a class="button button--secondary mr-2 font-caption" role="button" target="_blank" href="[[:href]]" target="[[:target]]">
-            [[if comments]]
-              <span class="font-caption d-inline-flex">
-                [[:text]]
-                <span class="comment">
-                  <img src={% static "v2/images/comment.svg" alt="Comment" %}>
-                  <span class="github-comment">
-                    [[:comments]]
-                  </span>
-                </span>
-              </span>
-            [[else]]
-              <span class="font-caption">[[:text]]</span>
-            [[/if]]
-          </a>
         [[else]]
           <a class="button [[if primary]]button--primary[[else]]button--secondary[[/if]] mr-2 font-caption [[if !enabled]]disabled[[/if]] [[:buttonclass]]" role="button" href="[[:href]]" target="[[:target]]" [[if modal]] data-toggle="modal" data-target=".share-modal" [[/if]]>
             <span class="font-caption">[[:text]]</span>