review: changes

- reused existing css class - fixed line overlappint content - update URL -> /how/funder & /how/contributor
gitcoinco · Jun 23, 2018 · 64a6098 · 64a6098
1 parent e2a2186
commit 64a6098
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/app/app/urls.py b/app/app/urls.py
@@ -180,8 +180,8 @@
     url(r'^extension/chrome?', retail.views.browser_extension_chrome, name='browser_extension_chrome'),
     url(r'^extension/firefox?', retail.views.browser_extension_firefox, name='browser_extension_firefox'),
     url(r'^extension/?', retail.views.browser_extension_chrome, name='browser_extension'),
-    path('funder', retail.views.how_it_works, name='how_it_works_funder'),
-    path('contributor', retail.views.how_it_works, name='how_it_works_contributor'),
+    path('how/funder', retail.views.how_it_works, name='how_it_works_funder'),
+    path('how/contributor', retail.views.how_it_works, name='how_it_works_contributor'),
 
     # basic redirect retail views
     url(r'^press/?', retail.views.presskit, name='press'),

diff --git a/app/assets/v2/css/gitcoin.css b/app/assets/v2/css/gitcoin.css
@@ -135,6 +135,10 @@ h4,
   padding-top: 40px;
 }
 
+.lighter {
+  font-weight: lighter;
+}
+
 .no-gutter {
   margin-right: 0;
   margin-left: 0;

diff --git a/app/assets/v2/css/howitworks.css b/app/assets/v2/css/howitworks.css
@@ -78,7 +78,13 @@
 
 .how-it-works__step-title,
 .how-it-works__step-text {
-  margin-top: 0.5em;
+  padding-top: 0.4em;
+  background: white;
+  z-index: 2;
+}
+
+.how-it-works__step-text {
+  padding-bottom: 6px;
 }
 
 .how-it-works__step-icon {

diff --git a/app/assets/v2/css/landing_page.css b/app/assets/v2/css/landing_page.css
@@ -228,11 +228,6 @@ body {
   background: #3E00FF;
 }
 
-.contributors-cta-text {
-  font-size: 1.2rem;
-  font-weight: 100;
-}
-
 .pricing_container {
   background-color: #F9F9F9;
   padding-bottom: 50rem;

diff --git a/app/retail/templates/how_it_works.html b/app/retail/templates/how_it_works.html
@@ -71,7 +71,7 @@ <h2 class="light">{% trans "In some cases..." %}</h2>
       <div class="container-fluid py-5 px-0 how-it-works-footer">
         <div class="row mb-4">
           <div class="col text-center text-white how-it-works-footer">
-            <div class="mt-4 contributors-cta-text">{% blocktrans %}For more details,
+            <div class="mt-4 font-subheader lighter">{% blocktrans %}For more details,
               please see <a target="_blank" rel="noopener noreferrer"
                 href="https://docs.google.com/document/d/1_U9IdDN8FIRMGAdLWCMl2BnqCTAv558QvyJiSWQfkbs/edit?usp=sharing">
               repo maintainer's guide</a> or the

diff --git a/app/retail/views.py b/app/retail/views.py
@@ -65,7 +65,7 @@ def index(request):
 def how_it_works(request):
     """Show How it Works / Funder page."""
     context = {
-        'active': 'how_it_works_funder' if request.path == '/funder' else 'how_it_works_contributor',
+        'active': 'how_it_works_funder' if request.path == '/how/funder' else 'how_it_works_contributor',
     }
     return TemplateResponse(request, 'how_it_works.html', context)