Skip to content

Commit

Permalink
worker can ding
Browse files Browse the repository at this point in the history
  • Loading branch information
@owocki
owocki committed Aug 27, 2018
1 parent c66cbc9 commit 62139a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/dashboard/templates/bounty/details.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ <h5 class="bounty-heading">{% trans "Funder" %}</h5>
</div>
[[/if]]
</div>
[[else activity_type == 'start_work' || activity_type == 'worker_approved' ]]
[[else activity_type == 'start_work' || activity_type == 'worker_approved' || activity_type == 'bounty_abandonment_warning || activity_type == 'worker_applied' ]]

This comment has been minimized.

Sign in to view

Copy link
@thelostone-mc

thelostone-mc Aug 31, 2018

Member

@owocki any particular reason why this activity_type == 'worker_applied' is needed ?
This prevents the code from going to the condition on L297 which enables owner to accept / reject approval for permissioned bounty

We should not owners dig a user just cause the applied for work right ?

This comment has been minimized.

Sign in to view

Copy link
@owocki

owocki Aug 31, 2018

Author Contributor

my mistake.. i think this is related to my confusion of the syntax of else vs elseif

please remove the worker applied provision to this if statement if it is causing an issue.

This comment has been minimized.

Sign in to view

Copy link
@owocki

owocki Sep 3, 2018

Author Contributor

@thelostone-mc did you ever submit a fix for this? i think this bug report might be related..

This comment has been minimized.

Sign in to view

Copy link
@thelostone-mc

thelostone-mc Sep 4, 2018

Member

@owocki Yeah you merged it in an hour after you put up the message 😅
#2131
<div class="col-12 col-md-7 started-status-column">
<div class="activity-status">
[[:text]]
Expand Down

0 comments on commit 62139a0

Please sign in to comment.