Skip to content

Commit

Permalink
review: incorported review feedbacks
Browse files Browse the repository at this point in the history
- replaced double-quotes with single
- removed left-rails on quote display
  • Loading branch information
Aditya Anand committed Mar 2, 2018
1 parent 1166bb0 commit 5daef05
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
13 changes: 6 additions & 7 deletions app/assets/v2/js/pages/bounty_details.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ var showWarningMessage = function (txid) {
$('#transaction_url').attr("href", link_url);
}

$(".left-rails").hide();
$("#bounty_details").hide();
$("#bounty_detail").hide();

Expand Down Expand Up @@ -200,7 +201,7 @@ var wait_for_tx_to_mine_and_then_ping_server = function(){
if(response.status == "200"){
console.log("success from sync/web", response);

// clear local data
// clear local data
localStorage[document.issueURL] = "";
document.location.href = document.location.href;
} else {
Expand Down Expand Up @@ -359,9 +360,9 @@ pull_interest_list(result['pk'], function(is_interested){
actions.push(entry);
}

render_actions(actions);
render_actions(actions);

});
});
}

var render_actions = function(actions){
Expand All @@ -370,7 +371,7 @@ var render_actions = function(actions){
var tmpl = $.templates("#action");
var html = tmpl.render(actions[l]);
$("#"+target).append(html);
};
};
}

var pull_bounty_from_api = function(){
Expand Down Expand Up @@ -406,7 +407,7 @@ var pull_bounty_from_api = function(){
$("#primary_view").css('display','none');
}).always(function(){
$('.loading').css('display', 'none');
});
});
}

var render_fulfillments = function(result){
Expand Down Expand Up @@ -492,5 +493,3 @@ var main = function(){
window.addEventListener('load', function() {
main();
});


2 changes: 1 addition & 1 deletion app/dashboard/templates/bounty_details.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{% include 'shared/nav_internal.html' %}
</div>
<div class="row no-gutter">
<div class="col-2" style="background: #eee; ">
<div class="col-2 left-rails" style="background: #eee; ">
{% include 'shared/current_balance.html' %}
{% include 'shared/sidebar_search.html' %}
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/dashboard/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ def profile(request, handle):
params = {
'title': 'Profile',
'active': 'profile_details',
'newsletter_headline': "Be the first to know about new funded issues.",
'newsletter_headline': 'Be the first to know about new funded issues.',
}

profile = profile_helper(handle)
Expand Down

0 comments on commit 5daef05

Please sign in to comment.