-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single data set with a custom color should not create legends for each category #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h category When creating a bar chart with a single data set and setting custom colors each category gets a legend-entry. See gitbrent#285 for last time that happened. I guess the idea is that if you pass in an array of colors to a single data set, that means that you want each category to have a different color. I think it would make more sense if creating legend entries for categories were an option that could be set. This solution instead add a check to avoid trying to color each category, if only a single color is passed.
Hi @gitbrent, anything else you need from me to help get this merged? |
@tvt - got any test cases? |
@gitbrent sure:
|
gitbrent
approved these changes
Jan 3, 2021
Thanks @tvt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a bar chart with a single data set and setting custom colors each category gets a legend-entry. See #285 for last time that happened.
I guess the idea is that if you pass in an array of colors to a single data set, that means that you want each category to have a different color.
I think it would make more sense if creating legend entries for categories were an option that could be set.
This solution instead add a check to avoid trying to color each category, if only a single color is passed.