Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape XML reserved characters so that we don't create invalid xml #171

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

kyrrigle
Copy link
Contributor

@kyrrigle kyrrigle commented Sep 5, 2017

Added an escapeXmlEntities function to escape XML reserved characters and use it wherever labels are being added to xml. Otherwise we end up with invalid XML.

@gitbrent gitbrent self-assigned this Sep 7, 2017
@gitbrent gitbrent merged commit d36fd97 into gitbrent:master Sep 7, 2017
@gitbrent
Copy link
Owner

gitbrent commented Sep 7, 2017

Thanks @kyrrigle !

@gitbrent gitbrent added this to the 1.8.0 milestone Sep 7, 2017
gitbrent pushed a commit that referenced this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants