Bar colors and axis tested #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dist/pptxgen.bundle.js # dist/pptxgen.bundle.js.map
gitbrent
pushed a commit
that referenced
this pull request
Aug 11, 2017
gitbrent
pushed a commit
that referenced
this pull request
Aug 11, 2017
gitbrent
approved these changes
Aug 11, 2017
gitbrent
pushed a commit
that referenced
this pull request
Aug 11, 2017
|
Thanks for the new features! |
This was referenced Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out how you did your tests, and saw where I was corrupting one of the examples. This made the code better - I was not accounting for there being more values than colors (duh).
I deleted the other two PRs and have all the changes in this one, tested in slide 10: