hyperlink and XML entities issue

[ZouhaierSebri]

Hi @gitbrent
i'm testing hyperlink both in image and text

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();
    slide .addText([
          {text: 'test A & B', options: {hyperlink: {url: 'https://github.com/gitbrent/pptxgenjs?a=1&b=2', tooltip: ' A&B'}}}
          ], {x: 0.62, y: 1, w: 5.3, h: 0.34, font_size: 14, color: '667184', bullet: {code: '27A2'}}
     );
pptx.save('testhyperlink');

The problem is in & because when i change & by & the exemple works fine.

as a solution i propose to use decodeXmlEntities()
line 2389 : change
Target="'+ rel.Target+'"
BY
Target="'+ decodeXmlEntities(rel.Target) +'"
line 1579 : change
tooltip="'+ (opts.hyperlink.tooltip ? opts.hyperlink.tooltip : '') +'"
BY
tooltip="'+ (opts.hyperlink.tooltip ? decodeXmlEntities(opts.hyperlink.tooltip) : '') +'"

[gitbrent]

Thanks @ZouhaierSebri !

I added decoding to both the text and the image hyperlink tooltips.

[ZouhaierSebri]

Hi @gitbrent
issue not fixed.
we need encoding for url

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();
    slide .addText([
          {text: 'test A & B', options: {hyperlink: {url: 'https://github.com/gitbrent/pptxgenjs?a=1&b=2', tooltip: ' A&B'}}}
          ], {x: 0.62, y: 1, w: 5.3, h: 0.34, font_size: 14, color: '667184', bullet: {code: '27A2'}}
     );
pptx.save('testhyperlink');

not work due to "a=1&b=2" in url
You are missing :: Target="'+ decodeXmlEntities(rel.Target) +'"

[lejard-h]

still having the issue on hyperlink, version 2.4.0 and Powerpoint 2016

var pptx = new PptxGenJS();
	var slide = pptx.addNewSlide();
	var opts = { x:1.0, y:1.0, fontSize:42, color:'00FF00',
        hyperlink: { url: 'https://google.fr', tooltip: 'Google' }
  }
slide.addText('Hello World!', opts);
pptx.save();

[gitbrent]

Hi @lejard-h

This code will indeed cause warnings on PPT startup.

You'll want to follow the example in the docs and use a complex text type instead (not a simple string with a global option)

Example

slide.addText(
    [{
        text: 'Hello world!',
        options: { hyperlink:{ url:'https://google.fr', tooltip:'Google' } }
    }],
    { x:1.0, y:1.0, fontSize:42, color:'00FF00' }
);

[Tehnix]

Having the exact same issue as @ZouhaierSebri, in the newest version of the library (2.5.0). Can't place any & in the URLs.

[gitbrent]

@Tehnix - Please open a new issue for problems using "&" in a URL.