Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check type before lowercasing to fix tagfield #326

Closed
wants to merge 1 commit into from
Closed

Check type before lowercasing to fix tagfield #326

wants to merge 1 commit into from

Conversation

cheeweep
Copy link

No description provided.

@cheeweep
Copy link
Author

Fixes #286

@uzquiano
Copy link
Member

I agree this would solve for the problem where the underlying data isn't a string (in that you're checking the type ahead of calling a method that may otherwise not exist). However, isn't it a problem if the user is putting a LowerCase text field on top of a non-textual element?

Is the real objective to check whether data is undefined or null?

@cheeweep
Copy link
Author

The real objective was to get it to work with the Tag Field. Not too sure what you meant by:

However, isn't it a problem if the user is putting a LowerCase text field on top of a non-textual element

@MaZZly
Copy link

MaZZly commented Apr 11, 2018

@uzquiano could this be merged? seems to be several issues related to this.

Also I tried on sample page to set data: "test, tag" (as you said about underlying data not being string) and it then instead complains about TypeError: val.join is not a function

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants