Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic auth: fix timing oracle #2609

Merged
merged 2 commits into from
Jan 13, 2021
Merged

basic auth: fix timing oracle #2609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
883f032
basic auth: fix timing oracle
Snawoot Jan 12, 2021
705955b
Merge branch 'master' into fix_basic_auth_timing_oracle
thinkerou Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package gin

import (
"crypto/subtle"
"encoding/base64"
"net/http"
"strconv"
Expand All @@ -30,7 +31,7 @@ func (a authPairs) searchCredential(authValue string) (string, bool) {
return "", false
}
for _, pair := range a {
if pair.value == authValue {
if subtle.ConstantTimeCompare([]byte(pair.value), []byte(authValue)) == 1 {
return pair.user, true
}
}
Expand Down