Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated s3 fixture (GSI-965) #126

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

TheByronHimes
Copy link
Member

Adds the S3MultiContainerFixture and FederatedS3Fixture that were introduced in the SMS. Maintains the same persistent and clean fixture variations that exist with other fixtures.
Because the S3MultiContainerFixture must know ahead of time about the containers it needs to create, it expects a fixture named storage_aliases to be defined with the same scope. If you try to use the fixture without having defined the storage_aliases fixture, you'll get an error.

Bumps version to 3.6.0.

@TheByronHimes TheByronHimes requested a review from mephenor August 28, 2024 14:03
@Cito Cito changed the title Federated s3 fixture GSI-965) Federated s3 fixture (GSI-965) Sep 2, 2024
Cito
Cito previously approved these changes Sep 2, 2024
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just a minor suggestion.

tests/unit/test_federated_s3.py Outdated Show resolved Hide resolved
tests/unit/test_federated_s3.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10668642079

Details

  • 51 of 55 (92.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 91.856%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hexkit/providers/s3/testutils/_fixtures.py 51 55 92.73%
Totals Coverage Status
Change from base Build 10594753571: 0.03%
Covered Lines: 1816
Relevant Lines: 1977

💛 - Coveralls

Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@TheByronHimes TheByronHimes merged commit 2c1cca7 into main Sep 3, 2024
8 checks passed
@TheByronHimes TheByronHimes deleted the feature/federated_s3_fixture_GSI-965 branch September 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants