Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Outbox Documents Lacking Metadata (GSI-924) #125

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

TheByronHimes
Copy link
Member

Before this PR, updating or deleting existing documents with an outbox DAO would result in a ResourceNotFoundError because the update/delete query assumed the existence of the __metadata__ field. This PR modifies the two relevant methods so the query results additionally include documents with a matching ID but no __metadata__ field.

Bumps version from 3.5.0 to 3.5.1.

@TheByronHimes TheByronHimes requested a review from mephenor August 27, 2024 10:56
@coveralls
Copy link

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10577525240

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.831%

Totals Coverage Status
Change from base Build 10181438495: 0.0%
Covered Lines: 1765
Relevant Lines: 1922

💛 - Coveralls

@TheByronHimes TheByronHimes marked this pull request as ready for review August 27, 2024 11:59
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheByronHimes TheByronHimes merged commit 8b4817a into main Aug 28, 2024
8 checks passed
@TheByronHimes TheByronHimes deleted the feature/uniform_outbox_dao_GSI-924 branch August 28, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants