Refactor S3 Testutils (GSI-762) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor some s3 fixture functions so they're in the fixture
This comment was marked as outdated.
This comment was marked as outdated.
Add leading underscore to s3 testutils files
Pull Request Test Coverage Report for Build 9696869004Details
💛 - Coveralls |
Cito
previously approved these changes
Jun 28, 2024
Update localstack image version to 3.5.0
Pull Request Test Coverage Report for Build 9712526144Details
💛 - Coveralls |
Cito
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps version from 3.2.2 to 3.2.3 because the changed items were not in use by any other microservices and are low-impact. Strictly following SemVer would mean bumping the major version number to 4 because the
delete_created_bucketsmethod was deleted, and some other functions were moved into the s3 fixture instead of existing on their own (and another was deleted).The fixtures were moved into
s3/testutils/_fixures.py, the supporting functions moved intos3/testutils/_utils.py, andtypical_workflowwas moved into its own module in that same directory. The imports are all funneled into__init__.pyto avoid disrupting consuming services.A list of current buckets is retrieved using the object storage's s3 client. The bucket deletion process iterates through the buckets and deletes them one by one, so neither the object storage nor test fixture need to track which buckets have been created.