Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --strip-path-prefix and update deps #62

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix --strip-path-prefix and update deps #62

merged 3 commits into from
Mar 29, 2024

Conversation

ggwpez
Copy link
Owner

@ggwpez ggwpez commented Mar 29, 2024

You can now use --strip-path-prefix=".*/" when you only render a single runtime to get a shorter paths for less clutter:

File Extrinsic Old New Change [%]
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs spend 266.11us 267.90us +0.67
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs void_spend 136.47us 137.12us +0.48
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs check_status 273.70us 274.38us +0.25
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs spend_local 360.21us 359.81us -0.11
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs approve_proposal 168.75us 168.53us -0.13

-->

File Extrinsic Old New Change [%]
pallet_treasury.rs spend 266.11us 267.90us +0.67
pallet_treasury.rs void_spend 136.47us 137.12us +0.48
pallet_treasury.rs check_status 273.70us 274.38us +0.25
pallet_treasury.rs spend_local 360.21us 359.81us -0.11
pallet_treasury.rs approve_proposal 168.75us 168.53us -0.13

ggwpez added 3 commits March 29, 2024 23:13
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez enabled auto-merge (squash) March 29, 2024 22:42
@ggwpez
Copy link
Owner Author

ggwpez commented Mar 29, 2024

cc @bkontur

@ggwpez ggwpez merged commit 9944e99 into master Mar 29, 2024
14 checks passed
@ggwpez ggwpez deleted the dev branch March 29, 2024 22:47
@bkontur
Copy link

bkontur commented Apr 2, 2024

wow, very cool useful feature,
exactly, when I was preparing results for weights: polkadot-fellows/runtimes#223, I was looking at those File columns, I was thinking about removing that with some bash script or command :)

I tried it and works, also with --strip-path-prefix="relay/polkadot/src/weights/" I can control if I want to show xcm benchmarks with subdirectory or not, cool :)

../../substrate-weight-compare/target/production/subweight compare commits \
          --path-pattern "./relay/polkadot/**/weights/**/*.rs" \
          --format markdown --no-color \
           --change added changed \
          --method asymptotic
          --ignore-errors \
          --strip-path-prefix="relay/polkadot/src/weights/" \
          remotes/polkadot-fellows/release-v1.1.2 \
          polkadot-fellows/main
| File                                    | Extrinsic                                           | Old      | New      | Change [%] |
| pallet_scheduler.rs                     | cancel                                              | 314.97us | 265.63us | -15.66     |
| xcm/pallet_xcm_benchmarks_generic.rs    | expect_pallet                                       | 8.87us   | 7.33us   | -17.31     |
| runtime_parachains_paras_inherent.rs    | enter_variable_disputes                             | 14.05ms  | 11.19ms  | -20.34     |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants