-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common : Update stb_image.h to latest version #9161
Conversation
There seems to be some formatting applied to the |
Oh yes, I see what you mean! I'm just wondering because I checked every commit in the upstream repo starting at 2.28 (and the few commits leading up to it) and non of them match the file that we currently have in llama.cpp. Then I verified the dev branch of upstream, but it doesn't match our current file either. I also checked the shasum on this pull request and it matched the latest shasum of upstream: Here are the steps that I took for this pull request:
Feel free to let me know if I'm misunderstanding or how to proceed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible by any chance that the original PR had custom formatting?
Ah, you are right. I got confused.
Need to exclude |
* Update stb_image.h to latest version Fixes ggerganov#7431 * Update .ecrc
* Update stb_image.h to latest version Fixes ggerganov#7431 * Update .ecrc
* Update stb_image.h to latest version Fixes ggerganov#7431 * Update .ecrc
Fixes #7431
See this issue in the original repo for more details: nothings/stb#1642 (comment)