Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: ask for more info in issue templates #10426

Conversation

JohannesGaessler
Copy link
Collaborator

This PR updates the issue templates and adds more fields to ask for potentially useful debugging information (since I find that a lot of the time I end up asking the same questions when I am the first responder to issues). A live version of the templates is on my fork.

@JohannesGaessler JohannesGaessler added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Nov 20, 2024
@JohannesGaessler JohannesGaessler force-pushed the github-update-issue-template branch from 5e64e24 to 9543d01 Compare November 20, 2024 11:10
@ngxson
Copy link
Collaborator

ngxson commented Nov 20, 2024

I think we should refactor the category for issues too, ref: #8097

@slaren
Copy link
Collaborator

slaren commented Nov 20, 2024

For me the severity tag is completely useless. People reporting bugs should not make that decision anyway.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 20, 2024
@JohannesGaessler JohannesGaessler force-pushed the github-update-issue-template branch from d757364 to 8f38ad6 Compare November 20, 2024 13:47
@JohannesGaessler
Copy link
Collaborator Author

I pushed refactored templates for compilation, model evaluation, and miscellaneous bugs. I don't know what information would be needed for e.g. a bug report concerning the server and would ask someone more knowledgeable than me to create such a template instead.

@ExtReMLapin
Copy link
Contributor

For me the severity tag is completely useless. People reporting bugs should not make that decision anyway.

Don't forget my™ problem is always more important than your™ problem.

@ngxson
Copy link
Collaborator

ngxson commented Nov 21, 2024

I don't know what information would be needed for e.g. a bug report concerning the server and would ask someone more knowledgeable than me to create such a template instead.

In most cases, having the log output is already enough to pinpoint the problem.

Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks. I think we can already merge this to see how it goes, and improve from this in the future.

@JohannesGaessler JohannesGaessler merged commit 599b3e0 into ggerganov:master Nov 22, 2024
7 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
* GitHub: ask for more info in issues [no ci]

* refactor issue templates to be component-specific

* more understandable issue description

* add dropdown for llama.cpp module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants