[spv-out] Add support for vector with vector multiplication #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
|
We should support |
kvark
reviewed
Nov 18, 2020
Timo-DK
commented
Nov 18, 2020
Timo-DK
force-pushed
the
spv-out-vector-multiply
branch
from
ad6c1a0 to
f896308
Compare
Timo-DK
force-pushed
the
spv-out-vector-multiply
branch
from
f896308 to
19428f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the Bevy shader thread (#210) and a requirement for a shader to work was vector with vector multiplication. I have used the same strategy as we came up with the normal multiplication: if it is not a float vector times float vector, we will default to an
ivec/`uvec multiplication.There are however two other vector types in GLSL at least:
bvecanddvec, but I don't think they are that commonly used, but that is just an assumption?