[pre-ll] Remove core alias in gfx_device_gl
#2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bors bot
added a commit
that referenced
this pull request
Aug 28, 2019
2980: [v0.18] Remove `core` alias in gfx_device_gl r=kvark a=alexheretic Fixes gfx_device_gl to compile on recent nightlies, fixes #2964. Cherry picked from #2979 into `v0.18`. PR checklist: - [x] tested examples with the following backends: gl Co-authored-by: Alex Butler <[email protected]>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2019
2979: [pre-ll] Remove `core` alias in gfx_device_gl r=kvark a=alexheretic Fixes `gfx_device_gl` to compile on recent nightlies, see #2964. I only removed the alias usage in this crate as it was the one that seems to cause issues. PR checklist: - [x] tested examples with the following backends: gl Co-authored-by: Alex Butler <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
gfx_device_glto compile on recent nightlies, see #2964. I only removed the alias usage in this crate as it was the one that seems to cause issues.PR checklist: