Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][metal] xcode11 supports metal on ios simulators #2873

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

mtak-
Copy link
Contributor

@mtak- mtak- commented Jun 27, 2019

This adds support for the iOS simulator. Xcode11 (in beta) supports metal in the simulator with pretty decent performance.

I had some trouble with spirv-cross as well (-std=c++14 doesn't appear to be set), but I hackily worked around that to test this.

Screen Shot 2019-06-26 at 5 02 34 PM

@mtak-
Copy link
Contributor Author

mtak- commented Jun 27, 2019

spirv_cross pr here: grovesNL/spirv_cross#103

@kvark
Copy link
Member

kvark commented Jun 27, 2019

Thank you!
Let's wait a tiny bit till spirv_cross is update, release a patch, and include the update in this PR.

@grovesNL
Copy link
Contributor

Published the updated spirv_cross 0.14.2

@kvark
Copy link
Member

kvark commented Jun 27, 2019

Could you squash those, please? (having individual commits compiling is good)

@mtak- mtak- force-pushed the ios-sim-support branch from dfca98f to 0437894 Compare June 27, 2019 17:33
@kvark
Copy link
Member

kvark commented Jun 27, 2019

Thank you!
bors r+

bors bot added a commit that referenced this pull request Jun 27, 2019
2873: [ios][metal] xcode11 supports metal on ios simulators r=kvark a=mtak-

This adds support for the iOS simulator. Xcode11 (in beta) supports metal in the simulator with pretty decent performance.

I had some trouble with spirv-cross as well (`-std=c++14` doesn't appear to be set), but I hackily worked around that to test this.

![Screen Shot 2019-06-26 at 5 02 34 PM](https://user-images.githubusercontent.com/6643140/60223018-4da6a900-9834-11e9-8709-7bfb4e68f1a8.png)


Co-authored-by: tyler <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 27, 2019

Build succeeded

@bors bors bot merged commit 0437894 into gfx-rs:master Jun 27, 2019
@mtak- mtak- deleted the ios-sim-support branch July 11, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants