hcvault: update API, add tests, tidy #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the Vault API and client to latest, adds more extensive test coverage, and general tidying of bits of code. The improvements are based on a fork of the key source in the Flux project's kustomize-controller, built due to SOPS' limitation around credential management without relying on runtime environment variables. - Vault API and client have been updated to latest. - It introduces a `Token` type which holds a Vault token, and can be applied to the `MasterKey`. When applied, the token is used in the Vault client configuration, instead of relying on the `VAULT_TOKEN` environment variables, or the `.vault-token` file in the user's home directory. This is most useful when working with SOPS as an SDK, in combination with e.g. a local key service server implementation. - Extensive test coverage. The forked version of this has compatability tests to ensure it works with current SOPS: - https://github.com/fluxcd/kustomize-controller/blob/62fb2d96a297c7e344050f46ee54074ef66dd438/internal/sops/hcvault/keysource_test.go#L130 - https://github.com/fluxcd/kustomize-controller/blob/62fb2d96a297c7e344050f46ee54074ef66dd438/internal/sops/hcvault/keysource_test.go#L202 Signed-off-by: Hidde Beydals <[email protected]>
Closed
ajvb
approved these changes
Jul 12, 2022
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Vault API and client to latest, adds more extensive
test coverage, and general tidying of bits of code.
The improvements are based on a fork of the key source in the Flux
project's kustomize-controller, built due to SOPS' limitation around
credential management without relying on runtime environment variables.
Tokentype which holds a Vault token, and can beapplied to the
MasterKey. When applied, the token is used in theVault client configuration, instead of relying on the
VAULT_TOKENenvironment variables, or the
.vault-tokenfile in the user's homedirectory. This is most useful when working with SOPS as an SDK, in
combination with e.g. a local key service server implementation.
The forked version of this has compatability tests to ensure it works
with current SOPS: