Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dashboards): Export Widget component props #81924

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

gggritso
Copy link
Member

Useful to other components and these names are better.

@gggritso gggritso requested a review from a team as a code owner December 10, 2024 19:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8352 1 8351 0
View the top 1 failed tests by shortest run time
WidgetBuilderSortBySelector renders and functions correctly
Stack Traces | 0.318s run time
Error: expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

Expected: ObjectContaining {"pathname": ".../org-slug/dashboard/1/", "query": ObjectContaining {"sort": ["-count"]}}
Received: {"pathname": ".../org-slug/dashboard/1/", "query": {"displayType": "line", "fields": ["transaction.duration", "count()", "id"], "sort": ["-count()"]}}

Number of calls: 1
    at Object.<anonymous> (.../widgetBuilder/components/sortBySelector.spec.tsx:111:26)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@gggritso gggritso merged commit a7387f1 into master Dec 10, 2024
42 checks passed
@gggritso gggritso deleted the ref/dashboards/export-widget-props branch December 10, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants